I had just inspected sqlunit's build.xml and found that it contains several hardcoded paths to external tools like jalopy, checkstyle and xdoclet.
I think that these paths should be isolated in external properties files. I already created these files on my local machine namely:
build.properties - configures the default locations of the above locations; should be store in CVS;
local.build.properties - gives the user the ability to overrides the default tools locations; if used should not be stored in CVS repository.
This will make sqlunit's build.xml more flexible, for example I use both Linux in home and Windows in my work so /usr/java/checkstyle is not an option for my Windows machine. Having local.build.properties will allow to override these settings.
Is it appropriate to commit these changes?
Regards
Ivan
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think it is, although, you should probably check in an empty build.user.properties file with the keys that need to be updated (if possible with some inline comments) so people know what to replace in these files if they need to.
-sujit
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I just added build.properties and touched build.xml to read its properties from build.properties, which contains the instructions how to override the properties settings.
Regards
Ivan
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Dear colleagues,
I had just inspected sqlunit's build.xml and found that it contains several hardcoded paths to external tools like jalopy, checkstyle and xdoclet.
I think that these paths should be isolated in external properties files. I already created these files on my local machine namely:
build.properties - configures the default locations of the above locations; should be store in CVS;
local.build.properties - gives the user the ability to overrides the default tools locations; if used should not be stored in CVS repository.
This will make sqlunit's build.xml more flexible, for example I use both Linux in home and Windows in my work so /usr/java/checkstyle is not an option for my Windows machine. Having local.build.properties will allow to override these settings.
Is it appropriate to commit these changes?
Regards
Ivan
Hi Ivan,
I think it is, although, you should probably check in an empty build.user.properties file with the keys that need to be updated (if possible with some inline comments) so people know what to replace in these files if they need to.
-sujit
I just added build.properties and touched build.xml to read its properties from build.properties, which contains the instructions how to override the properties settings.
Regards
Ivan
Thank you, I will download it tonight.
-sujit