Menu

Refactoring

Sujit Pal
2004-01-21
2004-01-22
  • Sujit Pal

    Sujit Pal - 2004-01-21

    I just started working with IDEA at work and Eclipse on my own. I am starting to like them, although I still think I can type faster than the autocomplete features :-). Coming from being a die-hard vi(m) user, the move was surprisingly easy, although my colleagues softened me up somewhat by refusing to put javadocs for their shared codebases online :-).

    Anyway, I found some simple things such as extra imports and stuff which Eclipse complains about, so I will probably clean that up as well as get more familiar with the two IDEs for the next release.

    Another thing that is kind of related to the "New Features for SQLUnit" thread is that we should refactor out hardcoded element names from the handlers as far as possible. Since the HandlerFactory uses the element name as the key, we could simply do something like this:

    IHandler handler = (IHandler) HandlerFactory.getInstance(element.getName());
    Object obj = handler.process(element);

    That way the handler code gets independent of decisions to move elements around, such as adding the batchcall element in the prepare. The DTD can be changed to allow that, and incorrect elements appearing in the test specification will be caught by the DTD.

    -sujit

     
    • Anonymous

      Anonymous - 2004-01-21

      Also if you could split some large functions to smaller ones that would be perfect.

       
    • Sujit Pal

      Sujit Pal - 2004-01-22

      Yeah, that too :-).

       

Log in to post a comment.