sqlrelay-discussion

[Sqlrelay-discussion] a small Makefile patch

[Renat S. <sr...@st...>]

Hello, David.

I am trying to debianize 0.42 and found that install goal for ruby api 
do not uses $(DESTDIR). The patch is attached.

-- 
Renat Sabitov   e-mail: sr...@st...
Stack Soft         jid: sr...@ja...

Re: [Sqlrelay-discussion] a small Makefile patch

[David M. <dav...@fi...>]

Cool.  I applied your patch.

I've been fighting DESTDIR with ruby for years.  The helper scripts in 
the src/api/ruby directory try to insert DESTDIR into their output, but 
they don't always succeed.  It's really complicated why, but if a 
platform builds its packages by calling:

export DESTDIR=somedir
make install

then everything works fine without your patch, but if a platform builds 
its packages by calling:

DESTDIR=somedir make install

then it fails to insert DESTDIR.  Apparently the rpmbuild command uses 
the first method, but the command for building debian packages uses the 
second.

It always seemed like I could get it to work for either platform, but 
never both.  When I first applied your patch, it ended up prepending 
DESTDIR twice when building RPM's, but I realized I could modify the 
ruby helper scripts to strip $(DESTDIR) out of their output and just let 
the Makefile handle DESTDIR itself.  Now, RPM's build fine.  I committed 
the code to CVS, let me know if it works on Debian too.

I'm ready to make the 0.42 release.  I wouldn't mind waiting a day or 
two though, if you think you can get the Debian build working quickly.

Dave

On 06/24/2011 10:32 AM, Renat Sabitov wrote:
> Hello, David.
>
> I am trying to debianize 0.42 and found that install goal for ruby api 
> do not uses $(DESTDIR). The patch is attached.
>
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense..
> http://p.sf.net/sfu/splunk-d2d-c1
>
> _______________________________________________________
> Unlimited Disk, Data Transfer, PHP/MySQL Domain Hosting
>                http://www.doteasy.com
>
>
> _______________________________________________
> Sqlrelay-discussion mailing list
> Sql...@li...
> https://lists.sourceforge.net/lists/listinfo/sqlrelay-discussion
>
>
> _______________________________________________________
> Unlimited Disk, Data Transfer, PHP/MySQL Domain Hosting
>                http://www.doteasy.com



_______________________________________________________
Unlimited Disk, Data Transfer, PHP/MySQL Domain Hosting
              http://www.doteasy.com 

Re: [Sqlrelay-discussion] a small Makefile patch

[Renat S. <sr...@st...>]

On 25.06.2011 05:56, David Muse wrote:
>
> I'm ready to make the 0.42 release.  I wouldn't mind waiting a day or 
> two though, if you think you can get the Debian build working quickly.
>
Although I got debian build working, I am not sure that it is correct. I 
used the old debian directory from 0.39 and modified it for the new 
debian standards and the new release. It builds well on Debian testing 
and stable with rudiments 0.33, but I am not a debian developer and 
really do not know how to put the package in debian repository. I tried 
some time ago to put 0.41 through mentors.debian.net, but my efforts was 
not succeded.

Further to patches and thoughs. It might be good to delete these files 
since they are made from .in:
init/netbsd/rc.d/sqlrelay
init/freebsd/rc.d/sqlrelay

debian.init.patch - there is a directory /etc/sqlrelay with file 
/etc/sqlrelay/sqlrelay

2 debian directories for rudiments and sqlrelay to build debian packages.

Re: [Sqlrelay-discussion] a small Makefile patch

[David M. <dav...@fi...>]

Thanks,  I removed the files that were getting created from the .in 
files.  Oops :)

I'm not sure about the Makefile patch though, the init script looks in 
the file /etc/sqlrelay for a list of instances to start at boot, or at 
least that's what it's supposed to do.  We could move that file to 
/etc/sqlrelay/sqlrelay but it would require that the init script be 
modified too.

A long time ago, some guys got SQL Relay into the debian repository and 
submitted similar debian directories for rudiments and sqlrelay.  I 
initially incorporated them into CVS, but later they asked me to pull 
them back out.  Apparently the debian package archive maintainers prefer 
to add them as patches rather than have them in the software distro.  I 
think it's so they can tweak on them without having to coordinate with 
anyone.

Dave

On 06/25/2011 10:00 PM, Renat Sabitov wrote:
> On 25.06.2011 05:56, David Muse wrote:
>>
>> I'm ready to make the 0.42 release.  I wouldn't mind waiting a day or 
>> two though, if you think you can get the Debian build working quickly.
>>
> Although I got debian build working, I am not sure that it is correct. 
> I used the old debian directory from 0.39 and modified it for the new 
> debian standards and the new release. It builds well on Debian testing 
> and stable with rudiments 0.33, but I am not a debian developer and 
> really do not know how to put the package in debian repository. I 
> tried some time ago to put 0.41 through mentors.debian.net, but my 
> efforts was not succeded.
>
> Further to patches and thoughs. It might be good to delete these files 
> since they are made from .in:
> init/netbsd/rc.d/sqlrelay
> init/freebsd/rc.d/sqlrelay
>
> debian.init.patch - there is a directory /etc/sqlrelay with file 
> /etc/sqlrelay/sqlrelay
>
> 2 debian directories for rudiments and sqlrelay to build debian packages.
>
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense..
> http://p.sf.net/sfu/splunk-d2d-c1
>
> _______________________________________________________
> Unlimited Disk, Data Transfer, PHP/MySQL Domain Hosting
>                http://www.doteasy.com
>
>
> _______________________________________________
> Sqlrelay-discussion mailing list
> Sql...@li...
> https://lists.sourceforge.net/lists/listinfo/sqlrelay-discussion
>
>
> _______________________________________________________
> Unlimited Disk, Data Transfer, PHP/MySQL Domain Hosting
>                http://www.doteasy.com



_______________________________________________________
Unlimited Disk, Data Transfer, PHP/MySQL Domain Hosting
              http://www.doteasy.com 

Re: [Sqlrelay-discussion] a small Makefile patch

[Renat S. <sr...@st...>]

On 28.06.2011 20:35, David Muse wrote:
> Thanks,  I removed the files that were getting created from the .in 
> files.  Oops :)
>
> I'm not sure about the Makefile patch though, the init script looks in 
> the file /etc/sqlrelay for a list of instances to start at boot, or at 
> least that's what it's supposed to do.  We could move that file to 
> /etc/sqlrelay/sqlrelay but it would require that the init script be 
> modified too.
>
There is another init script from the debian directory and it looks to 
/etc/sqlrelay/sqlrelay. Let Makefile stay as is and the debian build 
goes its way.
> A long time ago, some guys got SQL Relay into the debian repository 
> and submitted similar debian directories for rudiments and sqlrelay.  
> I initially incorporated them into CVS, but later they asked me to 
> pull them back out.  Apparently the debian package archive maintainers 
> prefer to add them as patches rather than have them in the software 
> distro.  I think it's so they can tweak on them without having to 
> coordinate with anyone.
>
I agree, separate debian directory is a better way.