Re: [Sqlrelay-discussion] [PATCH] Few tweaks to rudiments
Brought to you by:
mused
Menu
▾
▴
Re: [Sqlrelay-discussion] [PATCH] Few tweaks to rudiments
|
From: Dmitry S. <mi...@ca...> - 2005-08-26 15:23:25
|
On Fri, Aug 26, 2005 at 11:02:33AM -0400, David Muse wrote: > Yes, the http://www.firstworks.com/sqlrelay-0.37pre2.tar.gz tarball > contains both rudiments and sqlrelay and both contain > sun-compiler-specific updates. Well, I see. Now I get: CC -pipe -D_REENTRANT -D_THREAD_SAFE -D__EXTENSIONS__ -I../ -I../include -c signalclasses.C -o signalclasses.o >/dev/null 2>&1 /bin/sh ../libtool --mode=compile CC -pipe -D_REENTRANT -D_THREAD_SAFE -D__EXTENSIONS__ -I../ -I../include -c charstring.C -o charstring.lo CC -pipe -D_REENTRANT -D_THREAD_SAFE -D__EXTENSIONS__ -I../ -I../include -c charstring.C -KPIC -DPIC -o .libs/charstring.o CC: Warning: Option -pipe passed to ld, if ld is invoked, ignored otherwise "charstring.C", line 740: Error: Cannot return const char* from a function that should return char*. "charstring.C", line 744: Error: Cannot return const char* from a function that should return char*. "charstring.C", line 748: Error: Cannot return const char* from a function that should return char*. 3 Error(s) detected. make[1]: *** [charstring.lo] Error 1 make[1]: Leaving directory `/tmp/rudiments-0.29/src' make: *** [all] Error 2 I use Sun Studio 10. > > Dave > > On Fri, 2005-08-26 at 18:30 +0400, Dmitry Sivachenko wrote: > > Please note that I submitted a patch for *rudiments*, not for sqlrelay. > > > > > > > > On Fri, Aug 26, 2005 at 10:24:49AM -0400, Firstworks/4access wrote: > > > Take a look at http://www.firstworks.com/sqlrelay-0.37pre2.tar.gz > > > > > > I recently made a bunch of changes to support sun compilers including a > > > check to see if the compiler supports -Wall at configure-time. I > > > believe it also includes these fixes. > > > > > > I'm still working on some errors involving different compatibility > > > modes, but hopefully they'll be fixed soon. > > > > > > David Muse > > > dav...@fi... > > > > > > > > > On Fri, 2005-08-26 at 11:40 +0400, Dmitry Sivachenko wrote: > > > > Hello! > > > > > > > > I propose the following patch to rudiments (made against 0.28.2). > > > > > > > > Patch to configure.in is to eliminate mandatory '-Wall' from CPPFLAGS > > > > since there are compilers (say Sun Studio) which do not recongnize > > > > this flag. One can always add this switch to their CPPFLAGS if desired. > > > > > > > > Patch to charstring.h fixes the inconsistency between declarations in > > > > charstring.h and src/charstring.C. This is actually a bug which gcc hides, > > > > I suppose. > > > > > > > > Thanks! > > > > > > > > > > > > --- include/rudiments/charstring.h.orig Чтв Янв 27 06:35:07 2005 > > > > +++ include/rudiments/charstring.h Птн Авг 26 11:34:38 2005 > > > > @@ -119,7 +119,7 @@ > > > > const char *needle); > > > > // Returns true if "haystack" contains "needle" or > > > > // false otherwise. > > > > - static bool contains(const char *haystack, char needle); > > > > + static bool contains(const char *haystack, const char needle); > > > > // Returns true if "haystack" contains "needle" or > > > > // false otherwise. > > > > static char *findFirst(const char *haystack, > > > > @@ -126,7 +126,7 @@ > > > > const char *needle); > > > > // Returns a pointer to the first occurrance of "needle" > > > > // in "haystack" or NULL if not found. > > > > - static char *findFirst(const char *haystack, char needle); > > > > + static char *findFirst(const char *haystack, const char needle); > > > > // Returns a pointer to the first occurrance of "needle" > > > > // in "haystack" or NULL if not found. > > > > static char *findLast(const char *haystack, > > > > @@ -133,7 +133,7 @@ > > > > const char *needle); > > > > // Returns a pointer to the last occurrance of "needle" > > > > // in "haystack" or NULL if not found. > > > > - static char *findLast(const char *haystack, char needle); > > > > + static char *findLast(const char *haystack, const char needle); > > > > // Returns a pointer to the last occurrance of "needle" > > > > // in "haystack" or NULL if not found. > > > > > > > > --- configure.in.orig Чтв Апр 21 18:42:05 2005 > > > > +++ configure.in Птн Авг 26 11:31:13 2005 > > > > @@ -288,7 +288,7 @@ > > > > INCLUDE_ERROR="1") > > > > > > > > > > > > -CPPFLAGS="-Wall -D_REENTRANT $CPPFLAGS" > > > > +CPPFLAGS="-D_REENTRANT $CPPFLAGS" > > > > CXXFLAGS="$SMALLCODE $CXXFLAGS" > > > > > > > > AC_SUBST(CPPFLAGS) > > > > > > > > > > > > ------------------------------------------------------- > > > > SF.Net email is Sponsored by the Better Software Conference & EXPO > > > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > > > > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > > > > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > > > > _______________________________________________ > > > > Sqlrelay-discussion mailing list > > > > Sql...@li... > > > > https://lists.sourceforge.net/lists/listinfo/sqlrelay-discussion > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > SF.Net email is Sponsored by the Better Software Conference & EXPO > > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > > > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > > > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > > > _______________________________________________ > > > Sqlrelay-discussion mailing list > > > Sql...@li... > > > https://lists.sourceforge.net/lists/listinfo/sqlrelay-discussion > > > > > > ------------------------------------------------------- > > SF.Net email is Sponsored by the Better Software Conference & EXPO > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > > _______________________________________________ > > Sqlrelay-discussion mailing list > > Sql...@li... > > https://lists.sourceforge.net/lists/listinfo/sqlrelay-discussion > > > > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > _______________________________________________ > Sqlrelay-discussion mailing list > Sql...@li... > https://lists.sourceforge.net/lists/listinfo/sqlrelay-discussion |
