Thread: [SQLObject] svn: ._columns, etc., moved to sqlmeta
SQLObject is a Python ORM.
Brought to you by:
ianbicking,
phd
From: Ian B. <ia...@co...> - 2005-07-31 07:07:05
|
I just checked in a big refactoring, moving ._columns, ._columnDict, and some other similar attributes into sqlmeta. This touches a ton of stuff, though it should still be backward compatible for a number of those old attributes (with deprecation warnings). While the tests pass (except the unicode test under postgres, which I don't think is related to this), this is a pretty heavy refactoring. Just so you know what you're getting if you do an svn up. I've also added an interface file that outlines most of the public interface that will now be exposed: http://svn.colorstudy.com/trunk/SQLObject/docs/interface.py It's still missing a few objects, but I think it should be helpful. I'm hoping to do a little cleanup now that I've done the refactoring (which cleaned things up only slightly). Personally I'd lost track of what a lot of the parts did myself, and since "cleanup" often means "use canonical abstractions" (also known as DRY) then this should be useful. -- Ian Bicking / ia...@co... / http://blog.ianbicking.org |
From: Oleg B. <ph...@ph...> - 2005-07-31 08:20:24
|
On Sun, Jul 31, 2005 at 02:10:12AM -0500, Ian Bicking wrote: > I just checked in a big refactoring, moving ._columns, ._columnDict, and > some other similar attributes into sqlmeta. You've forgotten to fix manager/command.py. I fixed it. I also fixed inheritance. The new unofficial tarball is at http://phd.pp.ru/Software/Python/misc/SQLObject/ > (except the unicode test under postgres, which I don't think is related > to this), The unicode test passed here with Postgred in all Pythons - 2.2, 2.3, 2.4. Oleg. -- Oleg Broytmann http://phd.pp.ru/ ph...@ph... Programmers don't die, they just GOSUB without RETURN. |
From: Philippe N. <ph...@ba...> - 2005-08-01 06:14:00
|
Le dimanche 31 juillet 2005 =E0 02:10 -0500, Ian Bicking a =E9crit : > I just checked in a big refactoring, moving ._columns, ._columnDict, an= d=20 > some other similar attributes into sqlmeta. This touches a ton of=20 > stuff, though it should still be backward compatible for a number of=20 > those old attributes (with deprecation warnings). While the tests pass= =20 > (except the unicode test under postgres, which I don't think is related= =20 > to this), this is a pretty heavy refactoring. Just so you know what=20 > you're getting if you do an svn up. >=20 The unit-tests on inheritance are broken. Something about attribute '_SO_val_%(attrName)s' not found. I tried to track the bug on the inheritance code, without success ;( Philippe |
From: Oleg B. <ph...@ph...> - 2005-08-01 07:57:28
|
On Mon, Aug 01, 2005 at 08:13:49AM +0200, Philippe Normand wrote: > The unit-tests on inheritance are broken. Something about attribute > '_SO_val_%(attrName)s' not found. I tried to track the bug on the > inheritance code, without success ;( Even after I've submitted fixes? Oleg. -- Oleg Broytmann http://phd.pp.ru/ ph...@ph... Programmers don't die, they just GOSUB without RETURN. |
From: Philippe N. <ph...@ba...> - 2005-08-01 08:22:15
Attachments:
out.gz
|
Le lundi 01 ao=FBt 2005 =E0 11:57 +0400, Oleg Broytmann a =E9crit : > On Mon, Aug 01, 2005 at 08:13:49AM +0200, Philippe Normand wrote: > > The unit-tests on inheritance are broken. Something about attribute > > '_SO_val_%(attrName)s' not found. I tried to track the bug on the > > inheritance code, without success ;( >=20 > Even after I've submitted fixes? >=20 Yes. Attached is a dump of py.test results. I've tested on 2 different machines (one debian sid and one debian testing) and got the same results. Philippe |
From: Oleg B. <ph...@ph...> - 2005-08-01 16:36:32
|
On Mon, Aug 01, 2005 at 10:22:02AM +0200, Philippe Normand wrote: > Le lundi 01 ao?t 2005 ? 11:57 +0400, Oleg Broytmann a ?crit : > > On Mon, Aug 01, 2005 at 08:13:49AM +0200, Philippe Normand wrote: > > > The unit-tests on inheritance are broken. Something about attribute > > > '_SO_val_%(attrName)s' not found. I tried to track the bug on the > > > inheritance code, without success ;( > > > > Even after I've submitted fixes? > > Yes. Attached is a dump of py.test results. I've tested on 2 different > machines (one debian sid and one debian testing) and got the same > results. Very strange. I cannot reproduce it. All tests passed ok with Postgres and SQLite under Python 2.2, 2.3, 2.4. Debian sarge, but I've compiled all Pythons and SQLite myself. Oleg. -- Oleg Broytmann http://phd.pp.ru/ ph...@ph... Programmers don't die, they just GOSUB without RETURN. |
From: Philippe N. <ph...@ba...> - 2005-08-02 06:37:27
|
> > > > > > Even after I've submitted fixes? > > > > Yes. Attached is a dump of py.test results. I've tested on 2 different > > machines (one debian sid and one debian testing) and got the same > > results. > > Very strange. I cannot reproduce it. All tests passed ok with Postgres > and SQLite under Python 2.2, 2.3, 2.4. Debian sarge, but I've compiled all > Pythons and SQLite myself. > Well, then can somebody else on this mailing list try the unit-tests ? $ cd sqlobject/inheritance $ mkdir data $ py.test Philippe |