|
From: SourceForge.net <no...@so...> - 2007-03-03 14:26:49
|
Patches item #1673015, was opened at 2007-03-03 11:26 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) Assigned to: Nobody/Anonymous (nobody) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
|
From: SourceForge.net <no...@so...> - 2007-03-03 14:27:17
|
Patches item #1673015, was opened at 2007-03-03 11:26 Message generated for change (Comment added) made by llucax You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) Assigned to: Nobody/Anonymous (nobody) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- >Comment By: Leandro Lucarella (llucax) Date: 2007-03-03 11:27 Message: Logged In: YES user_id=240225 Originator: YES File Added: tablesdict.str.set-trunk.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
|
From: SourceForge.net <no...@so...> - 2007-03-27 14:21:14
|
Patches item #1673015, was opened at 2007-03-03 17:26 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open >Resolution: Later Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) >Assigned to: Oleg Broytmann (phd) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2007-03-27 18:21 Message: Logged In: YES user_id=4799 Originator: NO Will be applied after SQLObject would have switched to Python 2.3. ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2007-03-03 17:27 Message: Logged In: YES user_id=240225 Originator: YES File Added: tablesdict.str.set-trunk.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
|
From: SourceForge.net <no...@so...> - 2008-03-03 13:19:56
|
Patches item #1673015, was opened at 2007-03-03 17:26 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open >Resolution: Invalid Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) Assigned to: Oleg Broytmann (phd) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2008-03-03 16:19 Message: Logged In: YES user_id=4799 Originator: NO Please recreate the patch against the 0.10 branch: tablesUsedDict() has an additional parameter 'db'. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2007-03-27 18:21 Message: Logged In: YES user_id=4799 Originator: NO Will be applied after SQLObject would have switched to Python 2.3. ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2007-03-03 17:27 Message: Logged In: YES user_id=240225 Originator: YES File Added: tablesdict.str.set-trunk.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
|
From: SourceForge.net <no...@so...> - 2008-03-03 14:10:11
|
Patches item #1673015, was opened at 2007-03-03 11:26 Message generated for change (Comment added) made by llucax You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Invalid Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) Assigned to: Oleg Broytmann (phd) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- >Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 11:10 Message: Logged In: YES user_id=240225 Originator: YES Patch agains 0.10 attached. File Added: tablesdict.str.set-0.10.patch ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 10:19 Message: Logged In: YES user_id=4799 Originator: NO Please recreate the patch against the 0.10 branch: tablesUsedDict() has an additional parameter 'db'. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2007-03-27 11:21 Message: Logged In: YES user_id=4799 Originator: NO Will be applied after SQLObject would have switched to Python 2.3. ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2007-03-03 11:27 Message: Logged In: YES user_id=240225 Originator: YES File Added: tablesdict.str.set-trunk.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
|
From: SourceForge.net <no...@so...> - 2008-03-03 15:04:31
|
Patches item #1673015, was opened at 2007-03-03 17:26 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Invalid Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) Assigned to: Oleg Broytmann (phd) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2008-03-03 18:04 Message: Logged In: YES user_id=4799 Originator: NO Thank you. There is also a tables dict in the method Select.__sqlrepr__(). Can you update it, too? (sqlbuilder.py, lines 622-632). ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 17:10 Message: Logged In: YES user_id=240225 Originator: YES Patch agains 0.10 attached. File Added: tablesdict.str.set-0.10.patch ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 16:19 Message: Logged In: YES user_id=4799 Originator: NO Please recreate the patch against the 0.10 branch: tablesUsedDict() has an additional parameter 'db'. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2007-03-27 18:21 Message: Logged In: YES user_id=4799 Originator: NO Will be applied after SQLObject would have switched to Python 2.3. ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2007-03-03 17:27 Message: Logged In: YES user_id=240225 Originator: YES File Added: tablesdict.str.set-trunk.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
|
From: SourceForge.net <no...@so...> - 2008-03-03 15:15:39
|
Patches item #1673015, was opened at 2007-03-03 11:26 Message generated for change (Comment added) made by llucax You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Invalid Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) Assigned to: Oleg Broytmann (phd) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- >Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 12:15 Message: Logged In: YES user_id=240225 Originator: YES Sure, sorry about that... File Added: tablesdict.str.set-0.10.patch ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 12:04 Message: Logged In: YES user_id=4799 Originator: NO Thank you. There is also a tables dict in the method Select.__sqlrepr__(). Can you update it, too? (sqlbuilder.py, lines 622-632). ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 11:10 Message: Logged In: YES user_id=240225 Originator: YES Patch agains 0.10 attached. File Added: tablesdict.str.set-0.10.patch ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 10:19 Message: Logged In: YES user_id=4799 Originator: NO Please recreate the patch against the 0.10 branch: tablesUsedDict() has an additional parameter 'db'. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2007-03-27 11:21 Message: Logged In: YES user_id=4799 Originator: NO Will be applied after SQLObject would have switched to Python 2.3. ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2007-03-03 11:27 Message: Logged In: YES user_id=240225 Originator: YES File Added: tablesdict.str.set-trunk.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
|
From: SourceForge.net <no...@so...> - 2008-03-03 16:10:11
|
Patches item #1673015, was opened at 2007-03-03 17:26 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) Assigned to: Oleg Broytmann (phd) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2008-03-03 19:10 Message: Logged In: YES user_id=4799 Originator: NO There were these small problems: 1. E if t1 in tables: tables.remoce(t1) > AttributeError: 'set' object has no attribute 'remoce' [sqlobject/sqlbuilder.py:635] 2. E assert tablesUsedDict(x, None).keys() == ['not_yet_imported4 y'] > NameError: global name 'tablesUsedDict' is not defined [sqlobject/tests/test_sqlbuilder_importproxy.py:50] 3. E return d > NameError: global name 'd' is not defined [sqlobject/inheritance/__init__.py:21] I fixed them myself. Committed in the revisions 3281-3282 (0.10 and the trunk). Thank you! ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 18:15 Message: Logged In: YES user_id=240225 Originator: YES Sure, sorry about that... File Added: tablesdict.str.set-0.10.patch ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 18:04 Message: Logged In: YES user_id=4799 Originator: NO Thank you. There is also a tables dict in the method Select.__sqlrepr__(). Can you update it, too? (sqlbuilder.py, lines 622-632). ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 17:10 Message: Logged In: YES user_id=240225 Originator: YES Patch agains 0.10 attached. File Added: tablesdict.str.set-0.10.patch ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 16:19 Message: Logged In: YES user_id=4799 Originator: NO Please recreate the patch against the 0.10 branch: tablesUsedDict() has an additional parameter 'db'. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2007-03-27 18:21 Message: Logged In: YES user_id=4799 Originator: NO Will be applied after SQLObject would have switched to Python 2.3. ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2007-03-03 17:27 Message: Logged In: YES user_id=240225 Originator: YES File Added: tablesdict.str.set-trunk.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
|
From: SourceForge.net <no...@so...> - 2008-03-03 16:32:36
|
Patches item #1673015, was opened at 2007-03-03 11:26 Message generated for change (Comment added) made by llucax You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Leandro Lucarella (llucax) Assigned to: Oleg Broytmann (phd) Summary: Use sets instead of dicts for used tables. Initial Comment: Since dicts are used as plain sets there, why not to just use sets? Yeah, I know, because of Python 2.2 compatibility :) Maybe some day... ---------------------------------------------------------------------- >Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 13:32 Message: Logged In: YES user_id=240225 Originator: YES ups! Sorry again, I'm at work and didn't had the time to test it. Maybe I should waited to get home and do it right then =/ Thanks. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 13:10 Message: Logged In: YES user_id=4799 Originator: NO There were these small problems: 1. E if t1 in tables: tables.remoce(t1) > AttributeError: 'set' object has no attribute 'remoce' [sqlobject/sqlbuilder.py:635] 2. E assert tablesUsedDict(x, None).keys() == ['not_yet_imported4 y'] > NameError: global name 'tablesUsedDict' is not defined [sqlobject/tests/test_sqlbuilder_importproxy.py:50] 3. E return d > NameError: global name 'd' is not defined [sqlobject/inheritance/__init__.py:21] I fixed them myself. Committed in the revisions 3281-3282 (0.10 and the trunk). Thank you! ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 12:15 Message: Logged In: YES user_id=240225 Originator: YES Sure, sorry about that... File Added: tablesdict.str.set-0.10.patch ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 12:04 Message: Logged In: YES user_id=4799 Originator: NO Thank you. There is also a tables dict in the method Select.__sqlrepr__(). Can you update it, too? (sqlbuilder.py, lines 622-632). ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2008-03-03 11:10 Message: Logged In: YES user_id=240225 Originator: YES Patch agains 0.10 attached. File Added: tablesdict.str.set-0.10.patch ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2008-03-03 10:19 Message: Logged In: YES user_id=4799 Originator: NO Please recreate the patch against the 0.10 branch: tablesUsedDict() has an additional parameter 'db'. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2007-03-27 11:21 Message: Logged In: YES user_id=4799 Originator: NO Will be applied after SQLObject would have switched to Python 2.3. ---------------------------------------------------------------------- Comment By: Leandro Lucarella (llucax) Date: 2007-03-03 11:27 Message: Logged In: YES user_id=240225 Originator: YES File Added: tablesdict.str.set-trunk.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1673015&group_id=74338 |
