sqlobject-cvs

[<sub...@co...>]

Author: phd
Date: 2006-09-05 09:23:48 -0600 (Tue, 05 Sep 2006)
New Revision: 1904

Modified:
   SQLObject/trunk/sqlobject/main.py
Log:
Minor optimization - moved the condition out of the loop, used break.


Modified: SQLObject/trunk/sqlobject/main.py
===================================================================
--- SQLObject/trunk/sqlobject/main.py	2006-09-05 14:07:44 UTC (rev 1903)
+++ SQLObject/trunk/sqlobject/main.py	2006-09-05 15:23:48 UTC (rev 1904)
@@ -1279,10 +1279,11 @@
         return getID(obj)
 
     def _findAlternateID(cls, name, dbName, value, connection=None):
-        for key, column in cls.sqlmeta.columns.items():
-            if (key == name) and isinstance(column, col.SOUnicodeCol):
-                if isinstance(value, unicode):
+        if isinstance(value, unicode):
+            for key, column in cls.sqlmeta.columns.items():
+                if (key == name) and isinstance(column, col.SOUnicodeCol):
                     value = value.encode(column.dbEncoding)
+                    break
         return (connection or cls._connection)._SO_selectOneAlt(
             cls,
             [cls.sqlmeta.idName] +