sqlobject-cvs — CVS notification

[SQL-CVS] [ sqlobject-Patches-1576143 ] Bug in handling of non default foreign key values

[SourceForge.net <no...@so...>]

Patches item #1576143, was opened at 2006-10-12 21:18
Message generated for change (Comment added) made by trlandet
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1576143&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug in handling of non default foreign key values

Initial Comment:
se:

http://trac.turbogears.org/turbogears/ticket/1139

for bug description and patch.

Thanks, 

Tormod Ravnanger Landet



----------------------------------------------------------------------

Comment By: Tormod R Landet (trlandet)
Date: 2006-10-27 00:34

Message:
Logged In: YES 
user_id=1631055

Fix:

change the file sqlobject.inheritance.init line 218

from:

if col._default == sqlbuilder.NoDefault and col.name not in kw:

to:

if col._default == sqlbuilder.NoDefault and col.name not in
kw and (col.foreignName is None or col.foreignName not in kw):

----------------------------------------------------------------------

Comment By: Tormod R Landet (trlandet)
Date: 2006-10-27 00:31

Message:
Logged In: YES 
user_id=1631055

Seems there is a problem adding files

Testcase to show the bug:

from sqlobject import *
from sqlobject.inheritance import InheritableSQLObject

class Base(InheritableSQLObject):
    pass

class File(SQLObject):
    pass

class MyClass(Base):
    aFile = ForeignKey("Base")
    otherFile = ForeignKey("Base", default=None)

sqlhub.processConnection = connectionForURI('sqlite:/:memory:')

Base.createTable()
File.createTable()
MyClass.createTable()

file1 = File()
file2 = File()

print MyClass.sqlmeta.columnList
# [<SOStringCol childName default=None>, <SOForeignKey
aFileID connected to Base>, <SOForeignKey otherFileID
default=None connected to Base>]

object = MyClass(aFile=file1, otherFile=file2)

# Traceback (most recent call last):
#  File "/home/landet/work/eclipseworkspace/Diverse
Pythonscript/src/SQLObject_bugfixing/case.py", line 23, in ?
#    object = MyClass(aFile=file1, otherFile=file2)
#  File
"/home/landet/lib/python-2.4/SQLObject-0.7.1-py2.4.egg/sqlobject/declarative.py",
line 93, in _wrapper
#    return fn(self, *args, **kwargs)
#  File
"/home/landet/lib/python-2.4/SQLObject-0.7.1-py2.4.egg/sqlobject/main.py",
line 1198, in __init__
#    self._create(id, **kw)
#  File
"/home/landet/lib/python-2.4/SQLObject-0.7.1-py2.4.egg/sqlobject/inheritance/__init__.py",
line 219, in _create
#    raise TypeError, "%s() did not get expected keyword
argument %s" % (self.__class__.__name__, col.name)
# TypeError: MyClass() did not get expected keyword argument
aFileID


----------------------------------------------------------------------

Comment By: Tormod R Landet (trlandet)
Date: 2006-10-27 00:27

Message:
Logged In: YES 
user_id=1631055

Adding testcase

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1576143&group_id=74338

[SQL-CVS] [ sqlobject-Patches-1576143 ] Bug in handling of non default foreign key values

[SourceForge.net <no...@so...>]

Patches item #1576143, was opened at 2006-10-12 21:18
Message generated for change (Comment added) made by trlandet
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1576143&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug in handling of non default foreign key values

Initial Comment:
se:

http://trac.turbogears.org/turbogears/ticket/1139

for bug description and patch.

Thanks, 

Tormod Ravnanger Landet



----------------------------------------------------------------------

Comment By: Tormod R Landet (trlandet)
Date: 2006-10-27 00:31

Message:
Logged In: YES 
user_id=1631055

Seems there is a problem adding files

Testcase to show the bug:

from sqlobject import *
from sqlobject.inheritance import InheritableSQLObject

class Base(InheritableSQLObject):
    pass

class File(SQLObject):
    pass

class MyClass(Base):
    aFile = ForeignKey("Base")
    otherFile = ForeignKey("Base", default=None)

sqlhub.processConnection = connectionForURI('sqlite:/:memory:')

Base.createTable()
File.createTable()
MyClass.createTable()

file1 = File()
file2 = File()

print MyClass.sqlmeta.columnList
# [<SOStringCol childName default=None>, <SOForeignKey
aFileID connected to Base>, <SOForeignKey otherFileID
default=None connected to Base>]

object = MyClass(aFile=file1, otherFile=file2)

# Traceback (most recent call last):
#  File "/home/landet/work/eclipseworkspace/Diverse
Pythonscript/src/SQLObject_bugfixing/case.py", line 23, in ?
#    object = MyClass(aFile=file1, otherFile=file2)
#  File
"/home/landet/lib/python-2.4/SQLObject-0.7.1-py2.4.egg/sqlobject/declarative.py",
line 93, in _wrapper
#    return fn(self, *args, **kwargs)
#  File
"/home/landet/lib/python-2.4/SQLObject-0.7.1-py2.4.egg/sqlobject/main.py",
line 1198, in __init__
#    self._create(id, **kw)
#  File
"/home/landet/lib/python-2.4/SQLObject-0.7.1-py2.4.egg/sqlobject/inheritance/__init__.py",
line 219, in _create
#    raise TypeError, "%s() did not get expected keyword
argument %s" % (self.__class__.__name__, col.name)
# TypeError: MyClass() did not get expected keyword argument
aFileID


----------------------------------------------------------------------

Comment By: Tormod R Landet (trlandet)
Date: 2006-10-27 00:27

Message:
Logged In: YES 
user_id=1631055

Adding testcase

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1576143&group_id=74338

[SQL-CVS] [ sqlobject-Patches-1576143 ] Bug in handling of non default foreign key values

[SourceForge.net <no...@so...>]

Patches item #1576143, was opened at 2006-10-12 21:18
Message generated for change (Comment added) made by trlandet
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1576143&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug in handling of non default foreign key values

Initial Comment:
se:

http://trac.turbogears.org/turbogears/ticket/1139

for bug description and patch.

Thanks, 

Tormod Ravnanger Landet



----------------------------------------------------------------------

Comment By: Tormod R Landet (trlandet)
Date: 2006-10-27 00:27

Message:
Logged In: YES 
user_id=1631055

Adding testcase

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1576143&group_id=74338

[SQL-CVS] r2038 - home/phd/SQLObject/paramstyles/sqlobject/postgres

[<sub...@co...>]

Author: phd
Date: 2006-10-26 12:06:18 -0600 (Thu, 26 Oct 2006)
New Revision: 2038

Modified:
   home/phd/SQLObject/paramstyles/sqlobject/postgres/pgconnection.py
Log:
Merged patches from the revisions 2035:2037 from the trunk: a minor bugfix for integer ports by lekma <le...@ch...>.

Modified: home/phd/SQLObject/paramstyles/sqlobject/postgres/pgconnection.py
===================================================================
--- home/phd/SQLObject/paramstyles/sqlobject/postgres/pgconnection.py	2006-10-26 18:04:44 UTC (rev 2037)
+++ home/phd/SQLObject/paramstyles/sqlobject/postgres/pgconnection.py	2006-10-26 18:06:18 UTC (rev 2038)
@@ -45,7 +45,7 @@
             if usePygresql:
                 dsn_dict["host"] = "%s:%d" % (host, port)
             else:
-                dsn_dict["port"] = str(port)
+                dsn_dict["port"] = port
         if db:
             dsn_dict["database"] = db
         if user:

[SQL-CVS] r2037 - SQLObject/branches/0.7-bugfix/sqlobject/postgres

[<sub...@co...>]

Author: phd
Date: 2006-10-26 12:04:44 -0600 (Thu, 26 Oct 2006)
New Revision: 2037

Modified:
   SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py
Log:
A minor bugfix for integer ports by lekma <le...@ch...>.


Modified: SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py	2006-10-26 18:03:42 UTC (rev 2036)
+++ SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py	2006-10-26 18:04:44 UTC (rev 2037)
@@ -45,7 +45,7 @@
             if usePygresql:
                 dsn_dict["host"] = "%s:%d" % (host, port)
             else:
-                dsn_dict["port"] = str(port)
+                dsn_dict["port"] = port
         if db:
             dsn_dict["database"] = db
         if user:

[SQL-CVS] r2036 - SQLObject/trunk/sqlobject/postgres

[<sub...@co...>]

Author: phd
Date: 2006-10-26 12:03:42 -0600 (Thu, 26 Oct 2006)
New Revision: 2036

Modified:
   SQLObject/trunk/sqlobject/postgres/pgconnection.py
Log:
A minor bugfix for integer ports by lekma <le...@ch...>.


Modified: SQLObject/trunk/sqlobject/postgres/pgconnection.py
===================================================================
--- SQLObject/trunk/sqlobject/postgres/pgconnection.py	2006-10-26 16:42:05 UTC (rev 2035)
+++ SQLObject/trunk/sqlobject/postgres/pgconnection.py	2006-10-26 18:03:42 UTC (rev 2036)
@@ -45,7 +45,7 @@
             if usePygresql:
                 dsn_dict["host"] = "%s:%d" % (host, port)
             else:
-                dsn_dict["port"] = str(port)
+                dsn_dict["port"] = port
         if db:
             dsn_dict["database"] = db
         if user:

[SQL-CVS] r2035 - SQLObject/docs

[<sub...@co...>]

Author: phd
Date: 2006-10-26 10:42:05 -0600 (Thu, 26 Oct 2006)
New Revision: 2035

Modified:
   SQLObject/docs/News.txt
Log:
Minor updates and reformatting. Preparing docs for releases 0.7.2 and 0.8.


Modified: SQLObject/docs/News.txt
===================================================================
--- SQLObject/docs/News.txt	2006-10-26 16:38:41 UTC (rev 2034)
+++ SQLObject/docs/News.txt	2006-10-26 16:42:05 UTC (rev 2035)
@@ -45,7 +45,8 @@
   transactions.  Available as ``egg:SQLObject`` in Paste Deploy
   configuration files.
 
-* New joins! ManyToMany and OneToMany; not fully documented yet, but still more sensible and smarter.
+* New joins! ManyToMany and OneToMany; not fully documented yet, but still
+  more sensible and smarter.
 
 * SELECT FOR UPDATE
 
@@ -58,18 +59,20 @@
   test_sqlite_factory.py for examples.
 
 * SQLObject now disallows columns with names that collide with existing
-  methods, such as "_init", "expire", "set" and so on.
+  variables and methods, such as "_init", "expire", "set" and so on.
 
 Small Features
 --------------
 
 * Configurable client character set (encoding) for MySQL.
 
-* Added a close option to .commit(), so you can close the transaction as you commit it
+* Added a close option to .commit(), so you can close the transaction as
+  you commit it.
 
 * DecimalValidator.
 
-* Added .expireAll() methods to sqlmeta and connection objects, to expire all instances in those cases.
+* Added .expireAll() methods to sqlmeta and connection objects, to expire
+  all instances in those cases.
 
 * String IDs.
 
@@ -85,7 +88,8 @@
 Bug Fixes
 ---------
 
-* Fixed problem with sqlite and threads; connections are no longer shared between threads for sqlite (except for :memory:)
+* Fixed problem with sqlite and threads; connections are no longer shared
+  between threads for sqlite (except for :memory:).
 
 * The reference loop between SQLObject and SQLObjectState eliminated using
   weak references.
@@ -93,15 +97,6 @@
 SQLObject 0.7.2
 ===============
 
-Features & Interface
---------------------
-
-Small Features
---------------
-
-Bug Fixes
----------
-
 * Fixed a number of unicode-related problems with newer MySQLdb.
 
 SQLObject 0.7.1

[SQL-CVS] r2034 - SQLObject/branches/0.7-bugfix/docs

[<sub...@co...>]

Author: phd
Date: 2006-10-26 10:38:41 -0600 (Thu, 26 Oct 2006)
New Revision: 2034

Modified:
   SQLObject/branches/0.7-bugfix/docs/News.txt
Log:
Preparing docs for release 0.7.2.


Modified: SQLObject/branches/0.7-bugfix/docs/News.txt
===================================================================
--- SQLObject/branches/0.7-bugfix/docs/News.txt	2006-10-26 16:07:31 UTC (rev 2033)
+++ SQLObject/branches/0.7-bugfix/docs/News.txt	2006-10-26 16:38:41 UTC (rev 2034)
@@ -10,12 +10,6 @@
 SQLObject 0.7.2
 ===============
 
-Features & Interface
---------------------
-
-Small Features
---------------
-
 Bug Fixes
 ---------
 

[SQL-CVS] r2033 - home/phd/SQLObject/paramstyles/sqlobject

[<sub...@co...>]

Author: phd
Date: 2006-10-26 10:07:31 -0600 (Thu, 26 Oct 2006)
New Revision: 2033

Modified:
   home/phd/SQLObject/paramstyles/sqlobject/main.py
Log:
Merged patches from the revisions 2030:2032 from the trunkbugfixes for duplicate names test

Modified: home/phd/SQLObject/paramstyles/sqlobject/main.py
===================================================================
--- home/phd/SQLObject/paramstyles/sqlobject/main.py	2006-10-26 16:06:23 UTC (rev 2032)
+++ home/phd/SQLObject/paramstyles/sqlobject/main.py	2006-10-26 16:07:31 UTC (rev 2033)
@@ -319,10 +319,17 @@
             "add the column %r"
             % (soClass.__module__, soClass.__name__, name,
                sqlmeta.columnDefinitions[name], columnDef))
-        assert name not in dir(soClass), (
-            "The class %s.%s already has a variable or method %r, you cannot "
-            "add the column %r"
-            % (soClass.__module__, soClass.__name__, name, name))
+        # Collect columns from the parent classes to test
+        # if the column is not in a parent class
+        parent_columns = []
+        for base in soClass.__bases__:
+            if hasattr(base, "sqlmeta"):
+                parent_columns.extend(base.sqlmeta.columns.keys())
+        if name in dir(soClass):
+            assert  name in parent_columns or name == "childName", (
+                "The class %s.%s already has a variable or method %r, you cannot "
+                "add the column %r"
+                % (soClass.__module__, soClass.__name__, name, name))
         sqlmeta.columnDefinitions[name] = columnDef
         sqlmeta.columns[name] = column
         # A stable-ordered version of the list...

[SQL-CVS] r2032 - SQLObject/trunk/sqlobject

[<sub...@co...>]

Author: phd
Date: 2006-10-26 10:06:23 -0600 (Thu, 26 Oct 2006)
New Revision: 2032

Modified:
   SQLObject/trunk/sqlobject/main.py
Log:
A bug fix for duplicate names test in case of inheritance.


Modified: SQLObject/trunk/sqlobject/main.py
===================================================================
--- SQLObject/trunk/sqlobject/main.py	2006-10-26 15:55:32 UTC (rev 2031)
+++ SQLObject/trunk/sqlobject/main.py	2006-10-26 16:06:23 UTC (rev 2032)
@@ -326,7 +326,7 @@
             if hasattr(base, "sqlmeta"):
                 parent_columns.extend(base.sqlmeta.columns.keys())
         if name in dir(soClass):
-            assert name in parent_columns, (
+            assert  name in parent_columns or name == "childName", (
                 "The class %s.%s already has a variable or method %r, you cannot "
                 "add the column %r"
                 % (soClass.__module__, soClass.__name__, name, name))

[SQL-CVS] r2031 - SQLObject/trunk/sqlobject

[<sub...@co...>]

Author: phd
Date: 2006-10-26 09:55:32 -0600 (Thu, 26 Oct 2006)
New Revision: 2031

Modified:
   SQLObject/trunk/sqlobject/main.py
Log:
Fixed a bug in the duplicate names test - the test must exclude columns
from the parent classes in case of simple inheritance.


Modified: SQLObject/trunk/sqlobject/main.py
===================================================================
--- SQLObject/trunk/sqlobject/main.py	2006-10-24 16:29:07 UTC (rev 2030)
+++ SQLObject/trunk/sqlobject/main.py	2006-10-26 15:55:32 UTC (rev 2031)
@@ -319,10 +319,17 @@
             "add the column %r"
             % (soClass.__module__, soClass.__name__, name,
                sqlmeta.columnDefinitions[name], columnDef))
-        assert name not in dir(soClass), (
-            "The class %s.%s already has a variable or method %r, you cannot "
-            "add the column %r"
-            % (soClass.__module__, soClass.__name__, name, name))
+        # Collect columns from the parent classes to test
+        # if the column is not in a parent class
+        parent_columns = []
+        for base in soClass.__bases__:
+            if hasattr(base, "sqlmeta"):
+                parent_columns.extend(base.sqlmeta.columns.keys())
+        if name in dir(soClass):
+            assert name in parent_columns, (
+                "The class %s.%s already has a variable or method %r, you cannot "
+                "add the column %r"
+                % (soClass.__module__, soClass.__name__, name, name))
         sqlmeta.columnDefinitions[name] = columnDef
         sqlmeta.columns[name] = column
         # A stable-ordered version of the list...

[SQL-CVS] {tthemee}

[Laurel M. <vli...@am...>]

The first thing to do on Wednesday October 20 is to get in on EQTD. This is going to RISE
up next week.  There will be more than 100%
from the very beginning, so do it fast .
After the yesterday's promotion the  share price
raised on 116% and was 0.013.
Those lucky devils who bought  stocks at the price of 0.006
yesterday have already earned 100% of their investment.
And they will make more. 
Did you think of it yesterday? If not, think of it now.
Now the price is still rising.

More over, with oil markets retreating, big traders are turning to
gold, bringing it to levels never before seen.  EQTD has
made an notice of staggering proportions related to a
recent survey on one of their gold ownership.  The inside
scoop is great and we will be looking at a quadrupling of stock price once the public takes notice:

CHICAGO, ILLINOIS-(MARKETWIRE)-Oct 23, 2006 - Equal trading
is pleased to announce advertisement which inform us about far
exceeded expectations. The results from our British
Columbia property show 58,000 ounce potential.  Plans are
already underway for urgent development.  We look
forward to this superordinary discovery bringing value to
our shareholders.

At 600$ an ounce this discovery is worth 34.8 mil$.  With
865mil shares outstanding, this would give us a book value
of 0.04 (current price is under 1 cent).

The promotion will be continued till the end of this week!

[SQL-CVS] Attention, terrific growth!, important message

[Finance.com b. <all...@ro...>]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=iso-8859-1">
<META content="MSHTML 6.00.2900.2963" name=GENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<div align="left"> 
  <p><font face=Arial =
>NASA's Information Power Grid.</font><BR><BR><font face=Arial =
>seemingly went England's World Cup hopes.</font><BR><BR><IMG alt="" hspace=0 
src="cid:YB889U6X1HZY8LZZKBEY" align=baseline 
border=0><BR><font face=Arial =
>Cup. Only the 1990 finals produced more (four). England and Italy are the onlycandidate it should be said - or will he plump for Steven Gerrard?chested down and thumped home from 35 yards; Rodriguez wrote his name into</font><BR><font face=Arial =
>England are well served in defence, but more competition is needed for goalkeeper</font><BR><font face=Arial =
>week-out for Champions League winners Barcelona and know him to be the finest footballer on the planet.deliver, with negative coaches cancelling each other out and the goals drying up as a</font><BR><font face=Arial =
>days the vast majority of them already play in Europe by the time they feature in their first World Cup.</font></p>
  </div>
</BODY></HTML>

[SQL-CVS] Gold exchange

[Casey C. <hh...@am...>]

The only thing to do in tuesday is to get in on EQTD. It will SOAR
up next days.  There will be at least 100%
appreciation within the first few hours, so do it without delay.

With oil markets retreating, big traders are turning to
gold, driving it to levels never before seen.  EQTD has
made an view of staggering proportions related to a
recent survey on one of their gold ownership.  The inside
scoop is that we will be looking at a quadrupling of share price once the public takes notice:

CHICAGO, ILLINOIS-(MARKETWIRE)-Oct 23, 2006 - Equal trading
is pleased to announce notice results which have far
exceeded expectations. The results from our British
Columbia property show 58,000 ounce potential.  Plans are
already underway for urgent development.  We look
forward to this unordinary discovery bringing value to
our shareholders.

At 600$ an ounce this finding is worth 34.8 mil$.  With
865mil shares outstanding, this would give us a book value
of 0.04 (current price is under 1 cent).

Don't let it pass you by. The value and the opportunity are there.
This days is the lowest price it can be.
It's high time to buy in! The profitable moment to invest!
Good PR will help you to sell it with higher price later. 

[SQL-CVS] Serious note. You have to read.

[Douglas D. <qx...@al...>]

The great prognosis are made. 
The increase is up to 70% recently.
(MXXR) is the profitable deal and those who knows it is making money.
The drilling results of this highly capable oil partnership exceeded all its expectations. 
One time this fact hits the street there will be no stopping this one.
Right now it's about 0.025 but we are thinking it to triple. 
Once the information is made and the PR gets into full swing.
Don't hesitate and miss out.  We counsel you to buy today.
The key is getting in early and the time is pressing. We are told that Monday is the day this one will detonate. Take your place 
before that happens.

[SQL-CVS] [ sqlobject-Patches-1578415 ] exception called b/c of issue with millisecs in date string

[SourceForge.net <no...@so...>]

Patches item #1578415, was opened at 2006-10-16 13:34
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1578415&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: ptwobrussell (ptwobrussell)
Assigned to: Nobody/Anonymous (nobody)
Summary: exception called b/c of issue with millisecs in date string

Initial Comment:
A patch to fix an issue caused when pgdb returns a
date/time string that contains milliseconds in it:

col.py.orig is the original file. col.py is the updated
file

Patch is inline below:

--- col.py.orig 2006-10-16 14:11:30.000000000 -0400
+++ col.py      2006-10-16 14:13:28.000000000 -0400
@@ -941,7 +941,8 @@
                     else:
                         return
datetime.time(value.hour, value.minute, int(value.second))
             try:
-                stime = time.strptime(value, self.format)
+                #postgres might return a time value
with milliseconds. strip it or else change the format
string
+                stime =
time.strptime(value[value.rfind('.')], self.format)
             except:
                 raise validators.Invalid("expected an
date/time string of the '%s' format in the DateTimeCol
'%s', got %s %r instead" % \
                     (self.format, self.name,
type(value), value), value, state)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1578415&group_id=74338

[SQL-CVS] [ sqlobject-Patches-1578414 ] exception called b/c pgdb.Binary('') fails

[SourceForge.net <no...@so...>]

Patches item #1578414, was opened at 2006-10-16 13:32
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1578414&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: ptwobrussell (ptwobrussell)
Assigned to: Nobody/Anonymous (nobody)
Summary: exception called b/c pgdb.Binary('') fails

Initial Comment:
Patch is located inline below. Apparently, you need to
specialize the check because no Binary() method exists
as of pgdb v3.6+ (possibly earlier too, I don't know).
dbconnection.orig is the original file and
dbconnection.py is the updated file that now works

--- dbconnection.py.orig        2006-10-16
14:09:01.000000000 -0400
+++ dbconnection.py     2006-10-16 14:10:58.000000000 -0400
@@ -213,7 +213,10 @@
         self._pool = []
         self._poolLock = threading.Lock()
         DBConnection.__init__(self, **kw)
-        self._binaryType = type(self.module.Binary(''))
+        if self.usePygresql:
+            self._binaryType = type(self.module.BINARY)
+        else:
+            self._binaryType =
type(self.module.Binary(''))

     def _runWithConnection(self, meth, *args):
         conn = self.getConnection()

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1578414&group_id=74338

[SQL-CVS] r2024 - home/phd/SQLObject/paramstyles/sqlobject/tests

[<sub...@co...>]

Author: phd
Date: 2006-10-16 08:43:35 -0600 (Mon, 16 Oct 2006)
New Revision: 2024

Modified:
   home/phd/SQLObject/paramstyles/sqlobject/tests/test_sorting.py
Log:
Merged patches from the revisions 2021:2023 from the trunk:tests by Luke Opperman <lu...@me...> to test descending sorting.

Modified: home/phd/SQLObject/paramstyles/sqlobject/tests/test_sorting.py
===================================================================
--- home/phd/SQLObject/paramstyles/sqlobject/tests/test_sorting.py	2006-10-16 14:42:21 UTC (rev 2023)
+++ home/phd/SQLObject/paramstyles/sqlobject/tests/test_sorting.py	2006-10-16 14:43:35 UTC (rev 2024)
@@ -60,4 +60,13 @@
            ['zoe', 'tim', 'joe', 'joe', 'aj']
     assert firstList(Names.select().orderBy(Names.q.firstName)) == \
            ['aj', 'joe', 'joe', 'tim', 'zoe']
-
+    assert firstList(Names.select().orderBy('firstName').reversed()) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy('-firstName').reversed()) == \
+           ['aj', 'joe', 'joe', 'tim', 'zoe']
+    assert firstList(Names.select().orderBy(DESC(Names.q.firstName))) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy(Names.q.firstName).reversed()) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy(DESC(Names.q.firstName)).reversed()) == \
+           ['aj', 'joe', 'joe', 'tim', 'zoe']

[SQL-CVS] r2023 - SQLObject/branches/0.7-bugfix/sqlobject/tests

[<sub...@co...>]

Author: phd
Date: 2006-10-16 08:42:21 -0600 (Mon, 16 Oct 2006)
New Revision: 2023

Modified:
   SQLObject/branches/0.7-bugfix/sqlobject/tests/test_sorting.py
Log:
Tests by Luke Opperman <lu...@me...> to test descending sorting.


Modified: SQLObject/branches/0.7-bugfix/sqlobject/tests/test_sorting.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/tests/test_sorting.py	2006-10-16 14:42:00 UTC (rev 2022)
+++ SQLObject/branches/0.7-bugfix/sqlobject/tests/test_sorting.py	2006-10-16 14:42:21 UTC (rev 2023)
@@ -60,4 +60,13 @@
            ['zoe', 'tim', 'joe', 'joe', 'aj']
     assert firstList(Names.select().orderBy(Names.q.firstName)) == \
            ['aj', 'joe', 'joe', 'tim', 'zoe']
-
+    assert firstList(Names.select().orderBy('firstName').reversed()) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy('-firstName').reversed()) == \
+           ['aj', 'joe', 'joe', 'tim', 'zoe']
+    assert firstList(Names.select().orderBy(DESC(Names.q.firstName))) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy(Names.q.firstName).reversed()) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy(DESC(Names.q.firstName)).reversed()) == \
+           ['aj', 'joe', 'joe', 'tim', 'zoe']

[SQL-CVS] r2022 - SQLObject/trunk/sqlobject/tests

[<sub...@co...>]

Author: phd
Date: 2006-10-16 08:42:00 -0600 (Mon, 16 Oct 2006)
New Revision: 2022

Modified:
   SQLObject/trunk/sqlobject/tests/test_sorting.py
Log:
Tests by Luke Opperman <lu...@me...> to test descending sorting.


Modified: SQLObject/trunk/sqlobject/tests/test_sorting.py
===================================================================
--- SQLObject/trunk/sqlobject/tests/test_sorting.py	2006-10-12 15:02:21 UTC (rev 2021)
+++ SQLObject/trunk/sqlobject/tests/test_sorting.py	2006-10-16 14:42:00 UTC (rev 2022)
@@ -60,4 +60,13 @@
            ['zoe', 'tim', 'joe', 'joe', 'aj']
     assert firstList(Names.select().orderBy(Names.q.firstName)) == \
            ['aj', 'joe', 'joe', 'tim', 'zoe']
-
+    assert firstList(Names.select().orderBy('firstName').reversed()) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy('-firstName').reversed()) == \
+           ['aj', 'joe', 'joe', 'tim', 'zoe']
+    assert firstList(Names.select().orderBy(DESC(Names.q.firstName))) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy(Names.q.firstName).reversed()) == \
+           ['zoe', 'tim', 'joe', 'joe', 'aj']
+    assert firstList(Names.select().orderBy(DESC(Names.q.firstName)).reversed()) == \
+           ['aj', 'joe', 'joe', 'tim', 'zoe']

[SQL-CVS] [ sqlobject-Patches-1576143 ] Bug in handling of non default foreign key values

[SourceForge.net <no...@so...>]

Patches item #1576143, was opened at 2006-10-12 12:18
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1576143&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug in handling of non default foreign key values

Initial Comment:
se:

http://trac.turbogears.org/turbogears/ticket/1139

for bug description and patch.

Thanks, 

Tormod Ravnanger Landet



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1576143&group_id=74338

[SQL-CVS] r2021 - in home/phd/SQLObject/paramstyles/sqlobject: . tests

[<sub...@co...>]

Author: phd
Date: 2006-10-12 09:02:21 -0600 (Thu, 12 Oct 2006)
New Revision: 2021

Modified:
   home/phd/SQLObject/paramstyles/sqlobject/main.py
   home/phd/SQLObject/paramstyles/sqlobject/tests/test_auto.py
Log:
Merged patches from the revisions 2018:2020 from the trunk

Modified: home/phd/SQLObject/paramstyles/sqlobject/main.py
===================================================================
--- home/phd/SQLObject/paramstyles/sqlobject/main.py	2006-10-12 15:00:54 UTC (rev 2020)
+++ home/phd/SQLObject/paramstyles/sqlobject/main.py	2006-10-12 15:02:21 UTC (rev 2021)
@@ -318,8 +318,11 @@
             "The class %s.%s already has a column %r (%r), you cannot "
             "add the column %r"
             % (soClass.__module__, soClass.__name__, name,
-               sqlmeta.columnDefinitions[name],
-               columnDef))
+               sqlmeta.columnDefinitions[name], columnDef))
+        assert name not in dir(soClass), (
+            "The class %s.%s already has a variable or method %r, you cannot "
+            "add the column %r"
+            % (soClass.__module__, soClass.__name__, name, name))
         sqlmeta.columnDefinitions[name] = columnDef
         sqlmeta.columns[name] = column
         # A stable-ordered version of the list...

Modified: home/phd/SQLObject/paramstyles/sqlobject/tests/test_auto.py
===================================================================
--- home/phd/SQLObject/paramstyles/sqlobject/tests/test_auto.py	2006-10-12 15:00:54 UTC (rev 2020)
+++ home/phd/SQLObject/paramstyles/sqlobject/tests/test_auto.py	2006-10-12 15:02:21 UTC (rev 2021)
@@ -1,6 +1,8 @@
 from sqlobject import *
 from sqlobject.tests.dbtest import *
 from sqlobject import classregistry
+from py.test import raises
+
 try:
     from datetime import datetime
     now = datetime.now
@@ -62,6 +64,17 @@
         Phone.sqlmeta.delColumn(col, changeSchema=True)
         Person.sqlmeta.delJoin(join)
 
+    def _test_collidingName(self):
+        class CollidingName(SQLObject):
+            expire = StringCol()
+
+    def test_collidingName(self):
+        raises(AssertionError, Person.sqlmeta.addColumn, StringCol(name="name"))
+        raises(AssertionError, Person.sqlmeta.addColumn, StringCol(name="_init"))
+        raises(AssertionError, Person.sqlmeta.addColumn, StringCol(name="expire"))
+        raises(AssertionError, Person.sqlmeta.addColumn, StringCol(name="set"))
+        raises(AssertionError, self._test_collidingName)
+
 ########################################
 ## Auto class generation
 ########################################

[SQL-CVS] r2020 - SQLObject/docs

[<sub...@co...>]

Author: phd
Date: 2006-10-12 09:00:54 -0600 (Thu, 12 Oct 2006)
New Revision: 2020

Modified:
   SQLObject/docs/News.txt
Log:
SQLObject now disallows columns with names that collide with existing methods.


Modified: SQLObject/docs/News.txt
===================================================================
--- SQLObject/docs/News.txt	2006-10-12 14:52:38 UTC (rev 2019)
+++ SQLObject/docs/News.txt	2006-10-12 15:00:54 UTC (rev 2020)
@@ -57,6 +57,9 @@
   implementing functions or aggregates. See test_select.py and
   test_sqlite_factory.py for examples.
 
+* SQLObject now disallows columns with names that collide with existing
+  methods, such as "_init", "expire", "set" and so on.
+
 Small Features
 --------------
 

[SQL-CVS] [ sqlobject-Bugs-1463974 ] Column name collides with internal method

[SourceForge.net <no...@so...>]

Bugs item #1463974, was opened at 2006-04-04 08:20
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1463974&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: SQLObject release (specify)
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Patrick Coleman (ptrck)
Assigned to: Oleg Broytmann (phd)
Summary: Column name collides with internal method

Initial Comment:
Hi,

My database has a column 'expire' in a certain table.
It appears that when SQLObject calls expire() (line
778, dbconnection.py) on a cache object from that
table, rather than calling the expire method to expire
the object from cache it actually returns the value
from the 'expire' column, which being a Long of course
isn't callable, resulting in the attached exception.

I propose that internal methods used by SQLObject use
names that are unlikely to collide with column names
(perhaps by prepending __SQLObject__ or similar), and
that these internal names be documented so database
designers can avoid using names that may collide.

SQLObject is SQLObject-0.7.0-py2.4, as shipped with
Turbogears 0.8a3-py2.4.

Thanks,
Patrick
--
http://www.labyrinthdata.net.au

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-10-12 18:54

Message:
Logged In: YES 
user_id=4799

The code to check this is now in the trunk, revision 2019.
You can no longer have an "expire", "set" or any other name
that collides with existing methods.

----------------------------------------------------------------------

Comment By: Oleg Broytmann (phd)
Date: 2006-09-17 19:30

Message:
Logged In: YES 
user_id=4799

I am going to implement the third solution - do not allow to
add a column with a colliding name. There is a problem,
though, with fromDatabase. With fromDatabase=True SQLObject
draws columns from the database metadata, and there is a
chance of collision. I haven't decided yet what to do - just
raise an error, automatically rename the column in
SQLObject, allow user to override the name...

----------------------------------------------------------------------

Comment By: Patrick Coleman (ptrck)
Date: 2006-09-07 20:03

Message:
Logged In: YES 
user_id=646977

Thanks for the suggestion - I'll give it a try. 

However the problem, as I'm sure you realise, is *not* that
the column 'expire' in my database is inaccessible. The
problem is that *all transaction support* in SQLObject
completely breaks when a column called 'expire' exists
anywhere in the database. 

Specifically, rollbacks don't work at all which more or less
defeats the point of transactions.

The result for end users is that when they install SQLObject
on an existing database with a column called 'expire',
SQLObject breaks inexplicably. There is no documentation of
this behaviour, and so most people are just going to
conclude that SQLObject is broken, rather than performing
this workaround.

I agree that expire is a public method, but I feel that
perhaps the current behavior should be modified so that:

 - SQLObject noticies a column the same name as a public
method and throws a meaningful error; or
 - SQLObject noticies a column the same name as a public
method and overrides the public method with the column
method (but internally continues to use the non-column
public method, so that eg. transactions do not break as they
do now); or
 - SQLObject notices a column the same name as a public
method and refuses to publish the column method.

--Patrick

----------------------------------------------------------------------

Comment By: Oleg Broytmann (phd)
Date: 2006-09-07 19:43

Message:
Logged In: YES 
user_id=4799

But .expire is not an internal method - it is perfectly
valid public method. Now think you read or write
inst.__SQLObject__expire() in some code instead of
inst.expire()!

The workaround would be to made the column's name and db
anme different:

local_expire = DateTimeCol(dbName="expire")

Now you can access inst.local_expire (or whatever you name
it) and call inst.expire().

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1463974&group_id=74338

[SQL-CVS] r2019 - in SQLObject/trunk/sqlobject: . tests

[<sub...@co...>]

Author: phd
Date: 2006-10-12 08:52:38 -0600 (Thu, 12 Oct 2006)
New Revision: 2019

Modified:
   SQLObject/trunk/sqlobject/main.py
   SQLObject/trunk/sqlobject/tests/test_auto.py
Log:
Fixed the bug 1463974: Column name collides with internal method.
SQLObject now disallows columns with names that collide with existing methods,
such as "_init", "expire", "set" and so on.


Modified: SQLObject/trunk/sqlobject/main.py
===================================================================
--- SQLObject/trunk/sqlobject/main.py	2006-10-12 13:55:46 UTC (rev 2018)
+++ SQLObject/trunk/sqlobject/main.py	2006-10-12 14:52:38 UTC (rev 2019)
@@ -318,8 +318,11 @@
             "The class %s.%s already has a column %r (%r), you cannot "
             "add the column %r"
             % (soClass.__module__, soClass.__name__, name,
-               sqlmeta.columnDefinitions[name],
-               columnDef))
+               sqlmeta.columnDefinitions[name], columnDef))
+        assert name not in dir(soClass), (
+            "The class %s.%s already has a variable or method %r, you cannot "
+            "add the column %r"
+            % (soClass.__module__, soClass.__name__, name, name))
         sqlmeta.columnDefinitions[name] = columnDef
         sqlmeta.columns[name] = column
         # A stable-ordered version of the list...

Modified: SQLObject/trunk/sqlobject/tests/test_auto.py
===================================================================
--- SQLObject/trunk/sqlobject/tests/test_auto.py	2006-10-12 13:55:46 UTC (rev 2018)
+++ SQLObject/trunk/sqlobject/tests/test_auto.py	2006-10-12 14:52:38 UTC (rev 2019)
@@ -1,6 +1,8 @@
 from sqlobject import *
 from sqlobject.tests.dbtest import *
 from sqlobject import classregistry
+from py.test import raises
+
 try:
     from datetime import datetime
     now = datetime.now
@@ -62,6 +64,17 @@
         Phone.sqlmeta.delColumn(col, changeSchema=True)
         Person.sqlmeta.delJoin(join)
 
+    def _test_collidingName(self):
+        class CollidingName(SQLObject):
+            expire = StringCol()
+
+    def test_collidingName(self):
+        raises(AssertionError, Person.sqlmeta.addColumn, StringCol(name="name"))
+        raises(AssertionError, Person.sqlmeta.addColumn, StringCol(name="_init"))
+        raises(AssertionError, Person.sqlmeta.addColumn, StringCol(name="expire"))
+        raises(AssertionError, Person.sqlmeta.addColumn, StringCol(name="set"))
+        raises(AssertionError, self._test_collidingName)
+
 ########################################
 ## Auto class generation
 ########################################