Re: [SQLObject] ._create() and .set()

[Ian B. <ia...@co...>]

Oleg Broytmann wrote:
> On Mon, Nov 29, 2004 at 09:47:03AM -0600, Ian Bicking wrote:
> 
>>Oleg Broytmann wrote:
>>
>>>SQLObject._create() performs separation of values based on
>>>self._SO_plainSetters, creating "forDB" and "others", and calling
>>>self.set(**forDB).
>>>
>>>  Is the separation really neccessary? self.set() does the same
>>>separation itself. Why not just pass all values to self.set()?
>>
>>I think you're right, there's no real reason for this split.  It 
>>probably is left over from a (much) earlier time when the code didn't 
>>use .set while doing inserts (before _SO_creating).
> 
> 
>    Well, there is a minor semantic difference. ._create() tests if all
> passed keywords arguments are actually columns. .set() does not test it.
> One can do self.set(noncolumn="value"), which results in assignment
> self.noncolumn="value", but can't do ATable(noncolumn="value").
> 
>    Should we change the semantic of .set(), so it does not allow
> non-column keywords? In my opinion - yes, we should.

Yes, it's just an oversight that it doesn't check them.

-- 
Ian Bicking  /  ia...@co...  /  http://blog.ianbicking.org