Re: [SQLObject] [patch] sqlRepr refactoring + goodies

[Sidnei da S. <si...@re...>]

On Mon, Jul 14, 2003 at 11:34:47PM -0500, Ian Bicking wrote:
| On Mon, 2003-07-14 at 22:42, Sidnei da Silva wrote:
| > Howdy,
| > 
| > I just refactored the sqlRepr method into a separate module called
| > Converters and made it a registry, so one can register a custom
| > converter for a type SQLObject doesnt knows about without modifying
| > code. Attached is the patch for adding this functionality, plus some
| > whitespace cleaning and a DateCol (I dont know exactly what is the
| > plan for Date/DateTime/Timestamp, but I would like to know so I can
| > implement something better).
| > 
| > Two questions:
| > 
| > Q1: how hard is it to get me CVS access, so I can contribute more
| > easily?
| 
| Yeah, that'd be fine, if you give me your SF username.  

dreamcatcher

| So long as you
| don't mind me editing your work or whatever.  

No problem!

| Or if you have something
| extensive or experimental you want to do, it should probably go in a
| branch.  

Yeah, be sure. After being boldy warned by Jim Fulton 2 or 3 times you
never *ever* will want to do experimental stuff out of a branch again.
Trust me :)

| > Q2: whats the policy on adding new functionality? what about tests?
| 
| Well, I don't always add tests when I add new functionality.  But I am
| always wrong when I don't.  Therefore everyone else definitely must add
| tests ;)
| 
| Of course, it depends.  DateCol certainly doesn't need a test.

Ok. I'll try to add some here and there as I go browsing the source then.

[]'s
-- 
Sidnei da Silva (dreamcatcher) <si...@re...>
Debian GNU/Linux  2.4.20-powerpc ppc

"If that makes any sense to you, you have a big problem."
		-- C. Durance, Computer Science 234
-----------------------------------------------------------------------
Verified for virus by mail.redesul.com.br
Scanner: clamscan / ClamAV - Version 0.54 - Updated 08/07/2003