Re: [SQLObject] orderBy isinstance str check

[Andrew T. <at...@ga...>]

On Sat, Oct 25, 2014 at 12:09 PM, Oleg Broytman <ph...@ph...> wrote:

> > I recently discovered that some of my code was passing unicode strings to
> > orderBy and that this worked as long as the strings didn't start with
> "-".
> > When they did start with "-", the _mungeOrderBy check (line 69 in
> > sresults.py) didn't detect the "-" because the strings were of type
> unicode
> > and not type str and _mungeOrderBy checks for str and not basestring.
> >
> > I was just wondering if this was on purpose or not as it looks like there
> > are other places in the sqlobject code that do check for type basestring.
>
>    Certainly not. Just an oversight. If you replace 'str' with
> 'basestring' in 'if isinstance(orderBy, str)' does it work for you?
>

Yes, that works for me.  I wasn't sure if that was the only change that was
needed or if some of the other isinstance checks might need to be changed
to check basestring as well.