[SQL-CVS] r4545 - in SQLObject/branches/1.2: docs sqlobject

[<sub...@co...>]

Author: phd
Date: Sun Jun 24 06:14:24 2012
New Revision: 4545

Log:
Fixed a bug in sqlbuilder.Select.filter - removed comparison with SQLTrueClause.

Modified:
   SQLObject/branches/1.2/docs/News.txt
   SQLObject/branches/1.2/sqlobject/sqlbuilder.py
   SQLObject/branches/1.2/sqlobject/sresults.py

Modified: SQLObject/branches/1.2/docs/News.txt
==============================================================================
--- SQLObject/branches/1.2/docs/News.txt	Fri Jun 22 14:43:54 2012	(r4544)
+++ SQLObject/branches/1.2/docs/News.txt	Sun Jun 24 06:14:24 2012	(r4545)
@@ -7,6 +7,12 @@
 
 .. _start:
 
+SQLObject 1.2.4
+===============
+
+* Fixed a bug in sqlbuilder.Select.filter - removed comparison with
+  SQLTrueClause.
+
 SQLObject 1.2.3
 ===============
 

Modified: SQLObject/branches/1.2/sqlobject/sqlbuilder.py
==============================================================================
--- SQLObject/branches/1.2/sqlobject/sqlbuilder.py	Fri Jun 22 14:43:54 2012	(r4544)
+++ SQLObject/branches/1.2/sqlobject/sqlbuilder.py	Sun Jun 24 06:14:24 2012	(r4545)
@@ -618,12 +618,7 @@
         clause = self.ops['clause']
         if isinstance(clause, basestring):
             clause = SQLConstant('(%s)' % clause)
-
-        if clause == SQLTrueClause:
-            newClause = filter_clause
-        else:
-            newClause = AND(clause, filter_clause)
-        return self.newClause(newClause)
+        return self.newClause(AND(clause, filter_clause))
 
     def __sqlrepr__(self, db):
 

Modified: SQLObject/branches/1.2/sqlobject/sresults.py
==============================================================================
--- SQLObject/branches/1.2/sqlobject/sresults.py	Fri Jun 22 14:43:54 2012	(r4544)
+++ SQLObject/branches/1.2/sqlobject/sresults.py	Sun Jun 24 06:14:24 2012	(r4545)
@@ -122,7 +122,7 @@
             return self
         clause = self.clause
         if isinstance(clause, basestring):
-            clause = sqlbuilder.SQLConstant('(%s)' % self.clause)
+            clause = sqlbuilder.SQLConstant('(%s)' % clause)
         return self.newClause(sqlbuilder.AND(clause, filter_clause))
 
     def __getitem__(self, value):