[SQL-CVS] r3872 - in SQLObject/trunk: docs sqlobject/sqlite

[<sub...@co...>]

Author: phd
Date: 2009-04-29 10:08:22 -0600 (Wed, 29 Apr 2009)
New Revision: 3872

Modified:
   SQLObject/trunk/docs/News.txt
   SQLObject/trunk/sqlobject/sqlite/sqliteconnection.py
Log:
Merged revision 3870 from 0.9 branch:
a bug in SQLiteConnection.columnsFromSchema() that led to an infinite loop was fixed.


Modified: SQLObject/trunk/docs/News.txt
===================================================================
--- SQLObject/trunk/docs/News.txt	2009-04-29 16:07:35 UTC (rev 3871)
+++ SQLObject/trunk/docs/News.txt	2009-04-29 16:08:22 UTC (rev 3872)
@@ -188,6 +188,9 @@
   without this calling Transaction.close() calls connection.close() which
   is wrong.
 
+* A bug in SQLiteConnection.columnsFromSchema() that led to an infinite
+  loop was fixed.
+
 SQLObject 0.9.9
 ===============
 

Modified: SQLObject/trunk/sqlobject/sqlite/sqliteconnection.py
===================================================================
--- SQLObject/trunk/sqlobject/sqlite/sqliteconnection.py	2009-04-29 16:07:35 UTC (rev 3871)
+++ SQLObject/trunk/sqlobject/sqlite/sqliteconnection.py	2009-04-29 16:08:22 UTC (rev 3872)
@@ -313,9 +313,11 @@
         if not colData:
             raise ValueError('The table %s was not found in the database. Load failed.' % tableName)
         colData = colData[0].split('(', 1)[1].strip()[:-2]
-        while colData.find('(') > -1:
+        while True:
             start = colData.find('(')
+            if start == -1: break
             end = colData.find(')', start)
+            if end == -1: break
             colData = colData[:start] + colData[end+1:]
         results = []
         for colDesc in colData.split(','):