#239 Limit doesn't work in sqlbuilder

closed-fixed
General (125)
5
2008-04-29
2008-04-29
RicMoo
No

There is a name error in the sqlbuilder for the Select class.

Line 674 of sqlbuilder (0.10.0) reads:
end = start + limit

And no variable is named limit. Instead, it should be:
end = start + self.ops['limit']

If you try to use limit in a Select() constructor, you receive a NameError when you request the SQL be generated.

I have made this change locally to my version, and it works wonderfully, however I am not sure how to create patches. Hopefully somemone will pick this up as low hanging fruit.

Thanks,

RicMoo

Discussion

  • Oleg Broytman

    Oleg Broytman - 2008-04-29

    Logged In: YES
    user_id=4799
    Originator: NO

    Fixed in the revisions 3402, 3403 (branch 0.10 and the trunk). Thank you!

     
  • Oleg Broytman

    Oleg Broytman - 2008-04-29
    • assigned_to: nobody --> phd
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks