Re: [Sqlgrey-users] multiple read/write database support patch

[Lionel B. <lio...@bo...>]

Dan Faerch wrote the following on 03.02.2007 02:26 :
> Hey Paul.
>
> Thanks for the patch. Its pretty nice and clean :)
>
> Paul B. Henson wrote:
>   
> [...]
>   
>> Also, the patch moves the logging of the database error to before the
>> call to db_unavailable(). For some reason, DBI::errstr lost its value
>> during the call to db_unavailable(),

I see. disconnect() probably destroy $DBI:errstr. I didn't pay much
attention to this problem, but the solution seems obvious now :-)

>>  and with the logging message
>> afterwards, no error was printed.
>>   
>>     
> Im hoping Lionel has the time to double-check this. I dont know much 
> about that part of the code.:)
>   

I'm willing to test the patch, but I'd prefer to get one done against
CVS if possible or at least in unified diff format to make it easier to
integrate (the db_unavailable alone would be easy to handle but there is
a piece of code in the rest of the patch I'm not yet very familiar with).

Lionel.