Re: [Sqlgrey-users] idea for improving Discrimination feature

[Riaan K. <ria...@gm...>]

On 26/01/07, Dan Faerch <da...@ha...> wrote:
>
> Riaan Kok wrote:
> > How difficult would it be to allow the postfix attributes on both
> > sides of the regexp?
> >
>
> Without going into the discussion as to how usefull this would be,
> static comparison (no regex involved) is very simple to make and i see
> no the harm in it
>
> Ive made a "non-intrusive" patch. Everything will work as before (this i
> have already tested on a live-system).
> Only difference is, that it now also accepts:
> ==
> and
> !=
> (instead of =~ and !~ which means regex)
>
> Ie.:
> sender_domain == recipient_domain
> client_name != helo_name
>
>
> The patch is attached. Apply using:
> $ patch /path/to/sqlgrey < sqlgrey-discrimination-attr.patch
>
> Give it a try and tell me if it does the job for you.
>
> - Dan


sweet; nice and small patch; thanks!  I'll test it early this week, and if
there's any interesting statistics that pops out, I'll post them..

Riaan