From: Lionel B. <lio...@bo...> - 2015-07-23 16:58:40
|
Hi, Le 23/07/2015 15:40, Bruce Bodger a écrit : > [...] > Lionel, > > Does this comment from the distributed clients_fqdn_whitelist still apply? > > # Note you need the following two lines to allow both > # <lots of mtas>.example.com and example.com > # *.example.com > # example.com Yes it does. To be honest I wasn't happy about this little quirk when I coded the whitelists support and with experience I would not do it again the same way if I were starting from scratch. IIRC (I didn't look at SQLgrey code for quite some time) this is needlessly linked to internal SQLgrey structures involved in the whitelisting: regexp, globs and identity matching are done separately for performance reasons. I think I should have used a cleaner syntax and made the effort to translate it to the internal structures instead of looking for a direct mapping. As it didn't seem too bad and cleaner solutions would have broken backward compatibility this was left like this (and the comment was added to make sure people reading documentation like you were aware of it). Best regards, Lionel |