Re: [Sqlgrey-users] Another small update

[Dan F. <da...@ha...>]

Hehe.. You're running wild :)

Though im not quite following all the things youre talking about, help 
with the code is always appreciated. (Not usually being a perl-coder i 
have no idea what taint-mode actually is and so forth).

I did a diff of the version i have, and the one on your server. Probably 
due to running tidy, 5000+ lines were displayed.
Is there any way you can make the changes easier to read? Like, a diff 
for each new "feature" or major change. (sorta iterative/progressive diffs)

Sqlgrey is not my project, i just help out as co-developer (or something 
like that), but most of the code is made by Lionel Bouton and i must 
admit, i havent even read most of the code.
So unless I understand whats changed, bit by bit, i cant really put any 
of it into to the CVS (would be irresponsible of me right? ;).

Other than that, Lionel Bouton should be the one to accept code, if he's 
available at this time.

I hope that doesnt discourage you from helping making sqlgrey better. 
That is definitely not my intent.


- Dan Faerch


Bob Apthorpe wrote:
> Hi,
>
> I've run the refactored version for about a day now and I've cleaned up
> a runtime warning and added support for Time::HiRes if it's available[1].
>
> Things seem to be working properly. I have to fix the system() call in
> sendmail() that's breaking in taint-mode and review the updated 'killing
> spree' code (I suspect my quest for portable signal numbers broke some
> stuff.) One comment on taint mode: it took a handful of changes to make
> it run cleanly in taint mode which is IMHO pretty impressive.
>
> Also, I still have to work out some kinks where it still looks for the
> .conf file by default (rather than the .ini file that Config::Tiny
> expects) but it's simple to derive an .ini file from the original .conf
> file with:
>
> sqlgreyng --configfile=/etc/sqlgrey/sqlgrey.conf --showconfig=minimal \
> | tee /etc/sqlgrey/sqlgrey.ini
>
> In my case, it creates a file consisting of:
>
> ----
> db_pass=******
> db_type=mysql
> optmethod=optout
> reject_code=dunno
> ----
>
> with all other options set to their defaults. Use the above command with
> --showconfig=full to get a file with all the available options (good for
> converting an existing .conf file to an .ini) and --showconfig=default
> to show only the default settings (good for creating your own first .ini
> file.)
>
> To run the script, I modified the Debian init script to call sqlgreyng as:
>
>     /usr/sbin/sqlgreyng --configfile=/etc/sqlgrey/sqlgrey.ini -d
>
> Other than that, it seems to be stable. I think for right now I'm going
> to focus on the identified issues, the TODO file, migrating pieces into
> a module (`h2xs -AXn` is your friend...) and seeing if Regexp::Optimizer
> can help speed things up.
>
> -- Bob
>
> [1] Like Net::CIDR, it's ignored if it's not installed. So far it only
> gives more accurate timing stats in cleanup().
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Sqlgrey-users mailing list
> Sql...@li...
> https://lists.sourceforge.net/lists/listinfo/sqlgrey-users
>
>