Re: [Sqlgrey-users] 1.6.x and 1.7.x freezes

[Rupa S. (lists) <rup...@ru...>]

On 7/26/2005 4:27 AM, Lionel Bouton wrote:
>> Is it clean_method or cleanup_method?  I now have both in my
>> sqlgrey.conf file set to sync.
>>
>> 75: $dflt{clean_method}       = 'sync';
>> and then
>> 1403:    if ($self->{sqlgrey}{cleanup_method} eq 'sync') {
> 
> Hum...
> 
> Good catch. I'll patch the code to properly support "clean_method" as
> specified in the example sqlgrey.conf. Putting "cleanup_method = sync"
> in sqlgrey.conf should indeed avoid the fork in 1.6.4

It also looks like not all places use start_cleanup() and instead call
fork_cleanup() instead.  Also, the initialization of the sqlgrey hash
doesn't set cleanup_method which resulted in async being used no matter
what.

Patch attached.

-- 
 -Rupa