Re: [Sqlgrey-users] A smarter smart

[Michel B. <mi...@bo...>]

Le Mardi 15 F=E9vrier 2005 18:41, Michel Bouissou a =E9crit :
>
> IMHO, these regexp that are part of the "smart" routine are fixed "code=
"
> and should be considered as such, not parameters or whatever.

The regexps themselves are OK, but I find that the "line continuations" s=
till=20
cause problems with the part of the regexp immediately preceding the line=
=20
continuation, that doesn't work.

It seems that line continuation on regexps, that work perfectly in bash, =
don't=20
work OK in Perl.

I've abandoned the line continuations, even though I don't like very long=
=20
lines, it's better than introducing bugs with line continuations that don=
't=20
work as expected.

Please find attached a regexp patch (should be applied aftert the first o=
ne)=20
that makes them each on a single line.

Thinking again about your proposal to move these regexps to separate file=
s,=20
event though I don't see a real interest for doing this, if you still wan=
t to=20
do it, I suggest these files should be put into /usr/lib/something, and n=
ot=20
in /etc/sqlgrey. They shouldn't be considered as "user editable configura=
tion=20
files", but as fixed external code.

--=20
Michel Bouissou <mi...@bo...> OpenPGP ID 0xDDE8AC6E