From: Lionel B. <lio...@bo...> - 2005-01-12 23:06:39
|
Rene Joergensen wrote the following on 01/12/05 13:17 : >Hi there. > >SQLgrey is still running fine, upgraded to 1.4.1 a couple of days ago. > >I'm seeing the same Sys::Syslog errors as Michael (Debian testing). > > > Solved in my tree. Sys::Syslog doc isn't clear and it seems the behaviour changes between Net::Server or Sys::Syslog versions (don't realy know what happens to the Net::Server logopts content, I'll have to look into Net::Server and maybe Net::Server::Multiplex)... I have one FC3 system where it didn't log the pid but showed the error messages and a Gentoo where it log the pids (?!) and doesn't show any error (?!?!). Now they both don't show any errors, but I have yet to understand the pid logging with the Gentoo... >I've written a small patch for SQLgrey so it'll write out how long time >the cleaning took and how much was deleted. > Cool. Never thought of that but it's warmly welcomed. > It won't iterate on the >deleted lines in connect if the loglevel is too low > Even cooler ! > and i've also adjusted >the loglevel for some errors which i would like to see even when running >in quiet mode. > > > Ok, the only things I changed is the log level used for the time spent cleaning (in quiet mode I don't want a log line every 30 minutes) and the log syntax (it's a matter of taste). Maybe a log level won't suit us anymore as we don't put the same loglevel on the same information. We may have to switch to a : log=item1,item2,... format which in practice could look like - log=dbcleanup,awl_populate,delay,spam,awl_connections for someone who wants everything (the word 'everything' could be a shortcut), - log=dbcleanup for someone who wants to monitor the DB perf (the cleanup should be the most intensive DB op). errors and db conversion would implicitely be logged whatever we set log to. 1.5.x material. >I've attached the patch, use it if you can. > > It is now in my tree and your name in the Changelog. I'll have to add a THANKS file for you and most of the subscribers here. Last time I looked there were less than 20 people subscribed and a large proportion helped with sound enhancement requests, performance reports, bug reports and so on, thanks guys. I've yet to test it and then issue a 1.4.2 release. Thanks, Lionel. |