Re: [Sqlgrey-users] Suggestion: Comment field for net_whitelist

[Lionel B. <lio...@bo...>]

David Rees wrote the following on 17.11.2004 09:25 :

> I would like to see a comment column for the net_whitelist table.  
> That would help me keep track of why I added a particular net to the 
> table.
>

I'm in the process of obsoleting this table by creating a lookup file 
which will allow both IP and fqdn whitelisting. Adding a comment will be 
simple to do. You'll have something like :
132.4.5.6 # This mailserver never retries (it handles domain aaa)
196.54.3 # For a single message several servers in this class C can 
retry (domain a.com, b.org and c.net)

I'm doing this because it's simpler for people to use files for 
configuration and net_whitelist is only supported with PostgreSQL.

> Another question/comment:  I didn't see any indicies on the tables 
> (I'm using PostgreSQL.  In general do the tables stay small enough 
> that full table scans don't affect performance, or is that just 
> something you haven't gotten around to looking at yet?  That's 
> something I could spend some time on...


There are currently 2 lacks :
- no index for the connect table, but this table shouldn't grow much as 
it is cleaned up automatically.
- only a primary key (which creates an index implicitly) for other 
tables. An index on the timestamp could help the cleanup of these 
tables, all other operations are speed up by the primary key index.

I'm not yet considering adding indexes to the connect table (I've a 
problem with MySQL on this one and I've no performance problem with it 
reported). But adding an index on the timestamps of from_awl and 
domain_awl is on my TODO list. In the 1.3.x devel releases I've added on 
the fly database schema conversion support, so when 1.4.0 is out you'll 
have indexes on timestamps added automatically.

If there are Gentoo users, I've just tested a sqlgrey-1.3.1.ebuild, one 
of my test systems is now a working Gentoo SQLgrey install. Feel free to 
ask for the ebuild here if needed.

Happy greylisting !

Lionel