[Sqlgrey-users] Re: suggestion some small fixes for sqlgrey

[Lionel B. <lio...@bo...>]

Detlef Plotzky wrote the following on 10/22/04 10:01 :

>On Fri, 22 Oct 2004 09:09:51 +0200, Lionel Bouton wrote:
>
>  
>
>>I see you changed char(64) into varchar(255) for sender_name. From my 
>>understanding of the RFCs the name shouldn't be more than 64 chars. Is 
>>there a reason for the change ? Did you see more than 64 chars in the wild ?
>>    
>>
>No, it was just more easy to change all text fields to the same type, because the
>waste of space is the same in case of postgresql as far as I know.
>  
>

Yes you are right. I just checked both MySQL and PostgreSQL docs and 
apparently the performance difference of the two types is marginal. I 
guess I'll go the VARCHAR way then.
I'll add a 'dbversion' table to the database to make SQLgrey aware of 
the layout and where possible change it on the fly...

>Yesterday I have had some difficulties to send you an email, because the MX of sourceforge.net
>seems to do a call back to myself and then becomes greylisted. It didn#t retry within 30min.
>  
>

30 minutes is quite aggressive :
- the RFC is vague on the delays, but the longuest first delay I've seen 
advised is one hour,
- some mailing-lists managers have huge delays (more like 6 hours).

I bumped the default to 24 hours and the ratio between rejected spams 
and accepted spams (after more than 30 min delay) is still really high 
(like 10 for 1).

>So I put its IP in the whitelist.
>After about one hour the sqlqrey on every incoming mail was logging
>  yyyy/mm/dd-hh-mm-ss CONNECT TCP Peer: "127.0.0.1:xxxx Local: "127.0.0.1:2501"
>  Error: couldn't access connect table:
>  request: ...action=dunno
>  
>

I knew coding a fallback to 'dunno' when the database access went down 
wasn't a bad idea :-) You may have been spammed, but at least you still 
received your legit e-mails.

>But manual connect 'su sqlgrey -c "psql sqlgrey"' and "select * from connect;" works anyway.
>  
>

Hum quite surprising, especially since sqlgrey tries to reconnect to the 
database on such errors. I wonder if the changes you made to the data 
types might be related to this. The "Error: couldn't access connect 
table:" is indeed a generic error message. In reality there was an error 
when trying to execute a SQL statement involving the connect table.

>So I have configured my postfix back without sqlgrey and shut down sqlgrey daemon.
>
>  
>

I've some other enhancement to do before 1.2, I'll test the code with 
VARCHAR based tables when coding them.

Best regards,

Lionel.