From: Lionel B. <lio...@bo...> - 2010-02-01 20:50:28
|
Kyle Lanclos a écrit, le 02/01/2010 09:25 PM : > I wrote: > >> I've got a basic GNU autoconf scheme working with sqlgrey-1.8.0-rc1. >> > > ...and here it is. There's a fair number of steps involved. > > * The following files need to be renamed from 'filename' > to 'filename.in': > > Makefile > sqlgrey-logstats.pl > sqlgrey > sqlgrey.spec > tester.pl > update_sqlgrey_config > > * The attached patch needs to be applied, which modifies > all of the above-listed files to use @macro_definitions@ > instead of hard-coded path names. > > * There are three new files that land in the top-level source > directory (attached): > > aclocal.m4 > configure.ac > install-sh > > * The 'VERSION' file should be removed. The only place that the > version needs to be set is in configure.ac. If you really felt > like keeping the VERSION file around, rename it to VERSION.in, > etc. etc. etc. > > I would suggest invoking autoconf, and committing the resulting configure > script as part of the distributed source code, in addition to the above. > Yes, it doubles the total size of the package, and is amusing for that > reason. > > I did not do an exhaustive search through the source code base for > other hard-coded paths, so there may yet be more files that would > benefit from adopting this scheme. > > I also used arbitrary version numbers in configure.ac for the required > perl modules. Those are by no means real requirements. Someone that is > familiar with the usage of these modules might want to suggest more > realistic lower-bounds. > > The version requirement in configure.ac for a specific version of > autoconf (2.60), however, should be real. I confirmed that it does > not work with autoconf 2.59, but did my testing with autoconf 2.65. > It looks like 2.62 also works. > Isn't it a little too much work to get portability ? There was a temporary problem with a sed -i call, but are there any other portability problems (that can't be solved by installing the GNU tools or documenting some dependencies) ? What worries me is that autoconf would be another thing to master in order to contribute to the project (after a quick look I don't really understand much of the content of the added files). Lionel |