Re: [Sqlgrey-users] SQLgrey 1.8.0-rc1

[Michal L. <ml...@lo...>]

Hi Kyle,

On 01/23/2010 08:44 AM, Kyle Lanclos wrote:
> What about including some of the modifications posted here:
> 
> 	http://article.gmane.org/gmane.mail.postfix.sqlgrey/1033

I wasn't aware of these...

> ...in particular, the bits relating to logging? Those strike me as
> cross-platform improvements, and are 100% required to get sqlgrey
> functioning on Solaris.

Is this compatible with other Unix/Linux brands?

> Are the bits related to SPF functionality desirable? That sounds
> like a keen feature, even if I'm not a fan of how the dependency
> list grows exponentially when you require Mail::SPF::Query.

I'm sure SPF awareness would be nice to have. Ideally make it an
optional feature with an optional dependency. Have a look at my smtp-cli
script (http://smtp-cli.logix.cz) that has an optional mode for
composing messages from the command line arguments. If the required
modules are not found the feature is not available:

## MIME::Lite dependency is optional
my $mime_lite = eval { require MIME::Lite; 1; };
if (not $mime_lite) {
        warn("!!! MIME::Lite -- optional module not found\n");
}

Later on in the script it checks for $mime_lite before going down the
path where the module is needed.

> There are a lot of other small things I'm working against to get
> sqlgrey working on Solaris, and after working through enough of
> them, it's starting to get frustrating. It would be nice if these
> problems were solved with a basic autoconf setup, but it's not the
> same class of show-stopper.

I'm keen to accept patches that fix your problems, provided they won't
break sqlgrey for non-Solaris users.

> In particular, it would be nice if
> further GNU-isms are not assumed (for example, invoking sed -i in
> the Makefile) 

Oops, my bad. Will fix that.

> I've attached a patch to sqlgrey that contains the modifcations to
> the previously-posted logging behavior against the 1.8.0-rc1 release.

Thanks. I will have a look at it.

Michal