Re: [Sqlgrey-users] [SPAM] Re: [SPAM] Re: Patches for SQLgrey

[Lionel B. <lio...@bo...>]

Michal Ludvig a écrit, le 08/20/2009 02:19 PM :
> Frankly this is quite a major change to be implemented in the last
> minute before 1.8.0. I propose to postpone it after 1.8.0 - it's been
> waiting for two years, it can wait a month more.
>   

I agree.

> There's one thing I'd like to have for 1.8.0 - support for netmasks in
> client_ip_whitelist[.local]. At the moment it only accepts full IP
> (1.2.3.4) or class-c notation (1.2.3), what I'd like to have is a
> prefix-based notation (1.2.0.0/16 or 10.20.30.40/28).

I discouraged elaborate matchers for a reason : they are slow.
If you use full IP or class-c, you are looking up a hash entry. If you
do regex or prefix-based matching, this can become a full sequential
search on a list and this part of the code is hit on each and every mail
so it better be fast.

For 1.8.0 I'd like to have the fix for the erroneous database down/up
emails. The rest would be a plus.

>  Still accepting
> the current syntax as well of course. That's pretty easy to verify for
> correctness and should be safe to include.
>
> BTW Would you mind if I migrated the CVS repo to SVN or HG?
>   

We can ? That would be sweet. Git would be my choice, this is what I use
now and I just saw this is available on sourceforge.

Git (or Mercurial) would allow us to branch easily to prepare the fixes
for 1.8.0 and the evolutions for 1.8.x at the same time. But Mercurial
would be a speed bump for me :-(

Lionel