Re: [Sqlgrey-users] Patches for SQLgrey

[Lionel B. <lio...@bo...>]

Michal Ludvig a écrit, le 08/17/2009 03:47 PM :
> Hi guys,
>
> Two years after 1.7.6 it's a high time to put out a new release of
> SQLgrey. I wonder if there are any patches floating around that you'd
> like to have included in the upcoming release?
>
> So far I fixed some issues with IPv6 handling - namely fixed
> 'classc'/'smart' trimming of IPv6 addresses and added support for v6
> addrs for clients_ip_whitelist[.local].
>
> I bet there must be some other work as well that popped up in the two
> years since 1.7.6 release. Anyone?
>   

We should fix the case where a spammer sends a message to all MX of a
domain at the same time. The problem is that several SQLgrey instances
sharing the same database do the following (simplifying a bit) :
- check that the message doesn't match a whitelist (no),
- check if it is already in the connect table (it isn't),
- try to create an entry in the "connect" table.
Only one instance can complete the last step, all others get an SQL
error (and it's completely normal).

SQLgrey doesn't know about this case and thinks that there's a
connection problem with the database. It then :
- sends an email to the admin,
- reconnects to the database,
- later, when another action is requested and the database reacts
correctly, it sends an email saying all is OK with the db again.

I've seen a patch around that tries to solve the problem but IIRC it's
MySQL specific so it won't do.

What I'd like to do is simply to ignore errors occurring when SQLgrey
tries to write an entry in the connect table. If the database is really
down or misbehaving, SQLgrey has plenty other opportunities to detect
this and warn the admin (reading from the database on the next email
being processed for example).

> And one more thing - are there any major issues that should be fixed for
> the next release? Something that's holding us back from calling the
> 1.7.x codebase "stable"? I ask because I'm tempted to fork a new stable
> branch for 1.8.x versions.
>   

I agree with you on the 1.8.x naming. 1.7.6 is battle-tested for a long
time now.

Lionel