sqlalchemy-tickets Mailing List for SQLAlchemy (Page 65)
Brought to you by:
zzzeek
Menu
▾
▴
sqlalchemy-tickets — trac tickets and updates forwarded to this list
You can subscribe to this list here.
| 2006 |
Jan
|
Feb
|
Mar
(174) |
Apr
(50) |
May
(71) |
Jun
(129) |
Jul
(113) |
Aug
(141) |
Sep
(82) |
Oct
(142) |
Nov
(97) |
Dec
(72) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2007 |
Jan
(159) |
Feb
(213) |
Mar
(156) |
Apr
(151) |
May
(58) |
Jun
(166) |
Jul
(296) |
Aug
(198) |
Sep
(89) |
Oct
(133) |
Nov
(150) |
Dec
(122) |
| 2008 |
Jan
(144) |
Feb
(65) |
Mar
(71) |
Apr
(69) |
May
(143) |
Jun
(111) |
Jul
(113) |
Aug
(159) |
Sep
(81) |
Oct
(135) |
Nov
(107) |
Dec
(200) |
| 2009 |
Jan
(168) |
Feb
(109) |
Mar
(141) |
Apr
(128) |
May
(119) |
Jun
(132) |
Jul
(136) |
Aug
(154) |
Sep
(151) |
Oct
(181) |
Nov
(223) |
Dec
(169) |
| 2010 |
Jan
(103) |
Feb
(209) |
Mar
(201) |
Apr
(183) |
May
(134) |
Jun
(113) |
Jul
(110) |
Aug
(159) |
Sep
(138) |
Oct
(96) |
Nov
(116) |
Dec
(94) |
| 2011 |
Jan
(97) |
Feb
(188) |
Mar
(157) |
Apr
(158) |
May
(118) |
Jun
(102) |
Jul
(137) |
Aug
(113) |
Sep
(104) |
Oct
(108) |
Nov
(91) |
Dec
(162) |
| 2012 |
Jan
(189) |
Feb
(136) |
Mar
(153) |
Apr
(142) |
May
(90) |
Jun
(141) |
Jul
(67) |
Aug
(77) |
Sep
(113) |
Oct
(68) |
Nov
(101) |
Dec
(122) |
| 2013 |
Jan
(60) |
Feb
(77) |
Mar
(77) |
Apr
(129) |
May
(189) |
Jun
(155) |
Jul
(106) |
Aug
(123) |
Sep
(53) |
Oct
(142) |
Nov
(78) |
Dec
(102) |
| 2014 |
Jan
(143) |
Feb
(93) |
Mar
(35) |
Apr
(26) |
May
(27) |
Jun
(41) |
Jul
(45) |
Aug
(27) |
Sep
(37) |
Oct
(24) |
Nov
(22) |
Dec
(20) |
| 2015 |
Jan
(17) |
Feb
(15) |
Mar
(34) |
Apr
(55) |
May
(33) |
Jun
(31) |
Jul
(27) |
Aug
(17) |
Sep
(22) |
Oct
(26) |
Nov
(27) |
Dec
(22) |
| 2016 |
Jan
(20) |
Feb
(24) |
Mar
(23) |
Apr
(13) |
May
(17) |
Jun
(14) |
Jul
(31) |
Aug
(23) |
Sep
(24) |
Oct
(31) |
Nov
(23) |
Dec
(16) |
| 2017 |
Jan
(24) |
Feb
(20) |
Mar
(27) |
Apr
(24) |
May
(28) |
Jun
(18) |
Jul
(18) |
Aug
(23) |
Sep
(30) |
Oct
(17) |
Nov
(12) |
Dec
(12) |
| 2018 |
Jan
(27) |
Feb
(23) |
Mar
(13) |
Apr
(19) |
May
(21) |
Jun
(29) |
Jul
(11) |
Aug
(22) |
Sep
(14) |
Oct
(9) |
Nov
(24) |
Dec
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-27 21:26:19
|
#2898: get_table_names should not return views
-------------------------------------------+-------------------------------
Reporter: treeve | Owner: zzzeek
Type: defect | Status: new
Priority: medium | Milestone: 0.8.xx
Component: firebird | Severity: major - 1-3 hours
Resolution: | Keywords:
Progress State: needs questions answered |
-------------------------------------------+-------------------------------
Comment (by zzzeek):
so my suspicion here is that both queries work fine. But since the
Firebird FAQ refers to "view_blr" (http://www.firebirdfaq.org/faq174/),
might as well change it.
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2898#comment:5>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-27 21:23:20
|
#2898: get_table_names should not return views
-------------------------------------------+-------------------------------
Reporter: treeve | Owner: zzzeek
Type: defect | Status: new
Priority: medium | Milestone: 0.8.xx
Component: firebird | Severity: major - 1-3 hours
Resolution: | Keywords:
Progress State: needs questions answered |
-------------------------------------------+-------------------------------
Comment (by zzzeek):
link here:
http://www.alberton.info/firebird_sql_meta_info.html#.Ur3vXfZGni8 includes
*both* queries as interchangeable: "To exclude the VIEWs from the
resultset, you can write one of these queries"
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2898#comment:4>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-27 18:48:55
|
#2897: firebird dialect allows illegal names
-----------------------------------+-----------------------------------
Reporter: treeve | Owner: zzzeek
Type: defect | Status: closed
Priority: medium | Milestone: 0.8.xx
Component: firebird | Severity: trivial - <10 minutes
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+-----------------------------------
Changes (by zzzeek):
* status: new => closed
* component: cextensions => firebird
* resolution: => fixed
* severity: no triage selected yet => trivial - <10 minutes
* status_field: awaiting triage => completed/closed
Comment:
r92a1426c06c49f5b3db8cc41af 0.9 c24e825c37d9f1f33fa4c1722c 0.8 thanks!
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2897#comment:1>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-27 18:35:09
|
#2898: get_table_names should not return views
-------------------------------------------+-------------------------------
Reporter: treeve | Owner: zzzeek
Type: defect | Status: new
Priority: medium | Milestone: 0.8.xx
Component: firebird | Severity: major - 1-3 hours
Resolution: | Keywords:
Progress State: needs questions answered |
-------------------------------------------+-------------------------------
Comment (by zzzeek):
the existing query seems to be looking at the fields of the relation and
extrapolating the view name from that. The new query does look more
appropriate, however need a test case - how to produce a column that is
part of a view but has "view context" as NULL?
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2898#comment:3>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-27 18:31:30
|
#2898: get_table_names should not return views
-------------------------------------------+-------------------------------
Reporter: treeve | Owner: zzzeek
Type: defect | Status: new
Priority: medium | Milestone: 0.8.xx
Component: firebird | Severity: major - 1-3 hours
Resolution: | Keywords:
Progress State: needs questions answered |
-------------------------------------------+-------------------------------
Comment (by zzzeek):
changeset ra51c41e6305c3fcd64bdb10f8b (not pushed yet) adds a test with
this DEBUG output:
{{{
CREATE TABLE users (
user_id INTEGER NOT NULL,
test1 CHAR(5) NOT NULL,
test2 FLOAT NOT NULL,
parent_user_id INTEGER,
PRIMARY KEY (user_id),
FOREIGN KEY(parent_user_id) REFERENCES users (user_id) ON DELETE
CASCADE ON UPDATE CASCADE
)
CREATE TABLE email_addresses (
address_id INTEGER,
remote_user_id INTEGER,
email_address VARCHAR(20),
CONSTRAINT email_ad_pk PRIMARY KEY (address_id),
FOREIGN KEY(remote_user_id) REFERENCES users (user_id)
)
CREATE TABLE dingalings (
dingaling_id INTEGER NOT NULL,
address_id INTEGER,
data VARCHAR(30),
PRIMARY KEY (dingaling_id),
FOREIGN KEY(address_id) REFERENCES email_addresses (address_id)
)
INFO:sqlalchemy.engine.base.Engine:()
INFO:sqlalchemy.engine.base.Engine:COMMIT
INFO:sqlalchemy.engine.base.Engine:CREATE VIEW users_v AS SELECT * FROM
users
INFO:sqlalchemy.engine.base.Engine:()
INFO:sqlalchemy.engine.base.Engine:COMMIT
INFO:sqlalchemy.engine.base.Engine:CREATE VIEW email_addresses_v AS SELECT
* FROM email_addresses
INFO:sqlalchemy.engine.base.Engine:()
INFO:sqlalchemy.engine.base.Engine:COMMIT
test.dialect.test_suite.ComponentReflectionTest.test_get_tables_and_views
... INFO:sqlalchemy.engine.base.Engine:
SELECT DISTINCT rdb$relation_name
FROM rdb$relation_fields
WHERE rdb$system_flag=0 AND rdb$view_context IS NULL
INFO:sqlalchemy.engine.base.Engine:()
DEBUG:sqlalchemy.engine.base.Engine:Col ('RDB$RELATION_NAME',)
DEBUG:sqlalchemy.engine.base.Engine:Row ('DINGALINGS
',)
DEBUG:sqlalchemy.engine.base.Engine:Row ('EMAIL_ADDRESSES
',)
DEBUG:sqlalchemy.engine.base.Engine:Row ('USERS
',)
INFO:sqlalchemy.engine.base.Engine:
SELECT distinct rdb$view_name
FROM rdb$view_relations
INFO:sqlalchemy.engine.base.Engine:()
DEBUG:sqlalchemy.engine.base.Engine:Col ('RDB$VIEW_NAME',)
DEBUG:sqlalchemy.engine.base.Engine:Row ('EMAIL_ADDRESSES_V
',)
DEBUG:sqlalchemy.engine.base.Engine:Row ('USERS_V
',)
ok
}}}
as you can see, "WHERE rdb$system_flag=0 AND rdb$view_context IS NULL"
delivers us only table names. Can you please provide detail as to the
conditions/rationale for the patch? thanks.
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2898#comment:2>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-27 18:28:09
|
#2898: get_table_names should not return views
-------------------------------------------+-------------------------------
Reporter: treeve | Owner: zzzeek
Type: defect | Status: new
Priority: medium | Milestone: 0.8.xx
Component: firebird | Severity: major - 1-3 hours
Resolution: | Keywords:
Progress State: needs questions answered |
-------------------------------------------+-------------------------------
Changes (by zzzeek):
* component: cextensions => firebird
* severity: no triage selected yet => major - 1-3 hours
* status_field: awaiting triage => needs questions answered
Comment:
I can't reproduce this issue. Can you please provide a test case and full
information about DBAPI in use and Firebird version?
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2898#comment:1>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-27 17:28:59
|
#2898: get_table_names should not return views
-------------------------+-----------------------------------------
Reporter: treeve | Owner: zzzeek
Type: defect | Status: new
Priority: medium | Milestone: 0.8.xx
Component: cextensions | Severity: no triage selected yet
Keywords: | Progress State: awaiting triage
-------------------------+-----------------------------------------
firebird dialect returns views when using get_table_names
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2898>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-27 17:21:16
|
#2897: firebird dialect allows illegal names
-------------------------+-----------------------------------------
Reporter: treeve | Owner: zzzeek
Type: defect | Status: new
Priority: medium | Milestone: 0.8.xx
Component: cextensions | Severity: no triage selected yet
Keywords: | Progress State: awaiting triage
-------------------------+-----------------------------------------
in firebird, a name may not start with '_'
patch attached
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2897>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-22 00:52:54
|
#2884: crappy looking declarative error when bad mapper arg is passed
-----------------------------------+----------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: closed
Priority: medium | Milestone: 0.9.0
Component: orm | Severity: minor - half an hour
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+----------------------------------
Changes (by zzzeek):
* status: new => closed
* resolution: => fixed
* status_field: in queue => completed/closed
Comment:
this improves public_factory and also langhelpers.decorator.
r282a19d95251ecb033d30300b2
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2884#comment:1>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-21 00:13:32
|
#2852: errors in return_defaults() docs
-----------------------------------+----------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: closed
Priority: high | Milestone: 0.9.0
Component: documentation | Severity: minor - half an hour
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+----------------------------------
Changes (by zzzeek):
* status: new => closed
* resolution: => fixed
* status_field: in queue => completed/closed
Comment:
r730b23239365c03920
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2852#comment:1>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-20 15:27:19
|
#2896: fire_sequence logic can get tripped on a non-sequence backend
-----------------------------------+----------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: closed
Priority: high | Milestone: 0.8.xx
Component: sql | Severity: minor - half an hour
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+----------------------------------
Changes (by zzzeek):
* status: new => closed
* resolution: => fixed
* severity: major - 1-3 hours => minor - half an hour
* status_field: in queue => completed/closed
Comment:
rae3c57f492c5ade1afd8b010f7d9f2db740eb595 0.8
r65bd6ec96602ab8b755b9bc25638957a09477de6 0.9
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2896#comment:2>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-20 15:00:13
|
#2896: fire_sequence logic can get tripped on a non-sequence backend
---------------------------+-------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: new
Priority: high | Milestone: 0.8.xx
Component: sql | Severity: major - 1-3 hours
Resolution: | Keywords:
Progress State: in queue |
---------------------------+-------------------------------
Changes (by zzzeek):
* severity: very major - up to 2 days => major - 1-3 hours
Old description:
> {{{
> #!python
> from sqlalchemy import *
> e = create_engine("sqlite://", echo=True)
> metadata = MetaData()
>
> task = Table('y', metadata,
> Column('set_id', Integer, primary_key=True)
> )
> dataset = Table("x", metadata,
> Column("set_id", Integer, Sequence("some_seq"), primary_key=True)
> )
>
> dataset.append_constraint(ForeignKeyConstraint([dataset.c.set_id],
> [task.c.set_id]))
>
> metadata.create_all(e)
>
> e.execute(dataset.insert())
> }}}
New description:
{{{
#!python
from sqlalchemy import *
e = create_engine("sqlite://", echo=True)
metadata = MetaData()
task = Table('y', metadata,
Column('set_id', Integer, primary_key=True)
)
dataset = Table("x", metadata,
Column("set_id", Integer, Sequence("some_seq"), primary_key=True)
)
dataset.append_constraint(ForeignKeyConstraint([dataset.c.set_id],
[task.c.set_id]))
metadata.create_all(e)
e.execute(dataset.insert())
}}}
{{{
File "/Users/classic/dev/sqlalchemy/lib/sqlalchemy/engine/base.py", line
824, in _execute_context
context = constructor(dialect, self, conn, *args)
File "/Users/classic/dev/sqlalchemy/lib/sqlalchemy/engine/default.py",
line 512, in _init_compiled
self.__process_defaults()
File "/Users/classic/dev/sqlalchemy/lib/sqlalchemy/engine/default.py",
line 892, in __process_defaults
val = self.get_insert_default(c)
File "/Users/classic/dev/sqlalchemy/lib/sqlalchemy/engine/default.py",
line 848, in get_insert_default
return self._exec_default(column.default, column.type)
File "/Users/classic/dev/sqlalchemy/lib/sqlalchemy/engine/default.py",
line 832, in _exec_default
return self.fire_sequence(default, type_)
sqlalchemy.exc.StatementError: 'SQLiteExecutionContext' object has no
attribute 'fire_sequence' (original cause: AttributeError:
'SQLiteExecutionContext' object has no attribute 'fire_sequence') u'INSERT
INTO x (set_id) VALUES (?)' []
}}}
--
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2896#comment:1>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-20 14:59:46
|
#2896: fire_sequence logic can get tripped on a non-sequence backend
--------------------+--------------------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: new
Priority: high | Milestone: 0.8.xx
Component: sql | Severity: very major - up to 2 days
Keywords: | Progress State: in queue
--------------------+--------------------------------------------
{{{
#!python
from sqlalchemy import *
e = create_engine("sqlite://", echo=True)
metadata = MetaData()
task = Table('y', metadata,
Column('set_id', Integer, primary_key=True)
)
dataset = Table("x", metadata,
Column("set_id", Integer, Sequence("some_seq"), primary_key=True)
)
dataset.append_constraint(ForeignKeyConstraint([dataset.c.set_id],
[task.c.set_id]))
metadata.create_all(e)
e.execute(dataset.insert())
}}}
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2896>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-19 21:06:16
|
#2895: insert from select column ordering
-----------------------------------+----------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: closed
Priority: highest | Milestone: 0.8.xx
Component: sql | Severity: minor - half an hour
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+----------------------------------
Changes (by zzzeek):
* status: new => closed
* status_field: in queue => completed/closed
* resolution: => fixed
* severity: major - 1-3 hours => minor - half an hour
* milestone: 0.9.0 => 0.8.xx
Comment:
r2042493228a92fede38f39cd144d6ea74abbcb21 0.8
r5f76f29c15b7a23cfe29c5fbd22ad02452b6a2c0 0.9
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2895#comment:1>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-19 19:12:16
|
#2895: insert from select column ordering
---------------------+------------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: new
Priority: highest | Milestone: 0.9.0
Component: sql | Severity: major - 1-3 hours
Keywords: | Progress State: in queue
---------------------+------------------------------------
{{{
#!diff
diff --git a/test/sql/test_insert.py b/test/sql/test_insert.py
index e117153..22c6147 100644
--- a/test/sql/test_insert.py
+++ b/test/sql/test_insert.py
@@ -133,6 +133,20 @@ class InsertTest(_InsertTestBase,
fixtures.TablesTest, AssertsCompiledSQL):
checkparams={"name_1": "foo"}
)
+
+ def test_insert_from_select_select_alt_ordering(self):
+ table1 = self.tables.mytable
+ sel = select([table1.c.name, table1.c.myid,
]).where(table1.c.name == 'foo')
+ ins = self.tables.myothertable.insert().\
+ from_select(("othername", "otherid"), sel)
+ self.assert_compile(
+ ins,
+ "INSERT INTO myothertable (otherid, othername) "
+ "SELECT mytable.myid, mytable.name FROM mytable "
+ "WHERE mytable.name = :name_1",
+ checkparams={"name_1": "foo"}
+ )
+
def test_insert_mix_select_values_exception(self):
table1 = self.tables.mytable
sel = select([table1.c.myid, table1.c.name]).where(table1.c.name
== 'foo')
}}}
current output is:
{{{
INSERT INTO myothertable (otherid, othername) SELECT mytable.name,
mytable.myid FROM mytable WHERE mytable.name = :name_1
}}}
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2895>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-19 17:28:39
|
#2894: Add support for psycopg2 UNICODEARRAY extension
-----------------------------------+-----------------------------------
Reporter: snotling | Owner: zzzeek
Type: defect | Status: closed
Priority: medium | Milestone: 0.9.0
Component: postgres | Severity: trivial - <10 minutes
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+-----------------------------------
Changes (by zzzeek):
* status: new => closed
* milestone: => 0.9.0
* resolution: => fixed
* status_field: awaiting triage => completed/closed
Comment:
this was just done in rb2223ab14988317f86fcbb627
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2894#comment:1>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-19 16:44:40
|
#2894: Add support for psycopg2 UNICODEARRAY extension
----------------------+----------------------------------------
Reporter: snotling | Owner: zzzeek
Type: defect | Status: new
Priority: medium | Milestone:
Component: postgres | Severity: trivial - <10 minutes
Keywords: | Progress State: awaiting triage
----------------------+----------------------------------------
SQLAlchemy currently enables psycopg2 UNICODE extension when
"use_native_unicode" is requested.
The UNICODEARRAY extension should be also be included in this case, as in:
dialects/postgresql/psycopg2.py:
{{{
if self.dbapi and self.use_native_unicode:
def on_connect(conn):
extensions.register_type(extensions.UNICODE, conn)
extensions.register_type(extensions.UNICODEARRAY, conn)
fns.append(on_connect)
}}}
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2894>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-18 23:30:13
|
Batch modification to #2892 by zzzeek: milestone to 0.9.xx -- Tickets URL: <http://www.sqlalchemy.org/trac/query?id=2892> sqlalchemy <http://www.sqlalchemy.org/> The Database Toolkit for Python |
|
From: sqlalchemy <mi...@zz...> - 2013-12-18 23:27:01
|
#2893: enhance generic_repr to cascade down superclasses
-----------------------------------+-------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: closed
Priority: high | Milestone: 0.9.0
Component: sql | Severity: major - 1-3 hours
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+-------------------------------
Changes (by zzzeek):
* status: new => closed
* resolution: => fixed
* status_field: in queue => completed/closed
Comment:
r2692238f45ae4d2f46949dfa52b16132
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2893#comment:3>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-18 16:54:25
|
#2893: enhance generic_repr to cascade down superclasses
---------------------------+-------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: new
Priority: high | Milestone: 0.9.0
Component: sql | Severity: major - 1-3 hours
Resolution: | Keywords:
Progress State: in queue |
---------------------------+-------------------------------
Comment (by zzzeek):
this will fix https://bitbucket.org/zzzeek/alembic/issue/127/auto-
generate-seems-to-miss-unsigned
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2893#comment:2>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-18 16:53:16
|
#2893: enhance generic_repr to cascade down superclasses
---------------------------+-------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: new
Priority: high | Milestone: 0.9.0
Component: sql | Severity: major - 1-3 hours
Resolution: | Keywords:
Progress State: in queue |
---------------------------+-------------------------------
Comment (by zzzeek):
tests we can add when this works:
{{{
#!diff
diff --git a/test/dialect/mysql/test_types.py
b/test/dialect/mysql/test_types.py
index 071b844..fecf64e 100644
--- a/test/dialect/mysql/test_types.py
+++ b/test/dialect/mysql/test_types.py
@@ -142,8 +142,14 @@ class TypesTest(fixtures.TestBase,
AssertsExecutionResults, AssertsCompiledSQL):
]
for type_, args, kw, res in columns:
+ type_inst = type_(*args, **kw)
self.assert_compile(
- type_(*args, **kw),
+ type_inst,
+ res
+ )
+ repr_type = eval(repr(type_inst))
+ self.assert_compile(
+ repr_type,
res
)
@@ -239,8 +245,14 @@ class TypesTest(fixtures.TestBase,
AssertsExecutionResults, AssertsCompiledSQL):
]
for type_, args, kw, res in columns:
+ type_inst = type_(*args, **kw)
+ self.assert_compile(
+ type_inst,
+ res
+ )
+ repr_type = eval(repr(type_inst))
self.assert_compile(
- type_(*args, **kw),
+ repr_type,
res
)
}}}
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2893#comment:1>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-18 16:52:36
|
#2893: enhance generic_repr to cascade down superclasses
--------------------+------------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: new
Priority: high | Milestone: 0.9.0
Component: sql | Severity: major - 1-3 hours
Keywords: | Progress State: in queue
--------------------+------------------------------------
if we make MySQL's _String do this:
{{{
class _StringType(sqltypes.String):
"""Base for MySQL string types."""
def __repr__(self):
return util.generic_repr(self,
to_inspect=_StringType)
}}}
now we lose "length", unless we add it to additional_kw. This is silly,
the to_inspect attribute of generic_repr should accept a list of classes,
which we can assume propagates using kw.
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2893>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-17 23:03:52
|
Batch modification to #2847, #2861, #2866 by zzzeek: milestone to 0.9.xx -- Tickets URL: <http://www.sqlalchemy.org/trac/query?id=2847%2C2861%2C2866> sqlalchemy <http://www.sqlalchemy.org/> The Database Toolkit for Python |
|
From: sqlalchemy <mi...@zz...> - 2013-12-17 22:48:02
|
#2581: PostgreSQL-9.2 JSON datatype
-----------------------------------+-------------------------------
Reporter: plaes | Owner: zzzeek
Type: enhancement | Status: closed
Priority: medium | Milestone: 0.9.0
Component: postgres | Severity: major - 1-3 hours
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+-------------------------------
Comment (by zzzeek):
moved the serializer/deserializer arguments up to the dialect level, as
psycopg2 isn't compatible with a per-expression deserailizer.
rfec03c88d659bf9a0b102dd328afac
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2581#comment:20>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
|
From: sqlalchemy <mi...@zz...> - 2013-12-17 22:18:01
|
#2581: PostgreSQL-9.2 JSON datatype
-----------------------------------+-------------------------------
Reporter: plaes | Owner: zzzeek
Type: enhancement | Status: closed
Priority: medium | Milestone: 0.9.0
Component: postgres | Severity: major - 1-3 hours
Resolution: fixed | Keywords:
Progress State: completed/closed |
-----------------------------------+-------------------------------
Changes (by zzzeek):
* status: new => closed
* status_field: in queue => completed/closed
* resolution: => fixed
* milestone: 0.9.xx => 0.9.0
Comment:
see pullreq: https://github.com/zzzeek/sqlalchemy/pull/50/
additional changes: 73013914e7eae2a0480492ece08
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2581#comment:19>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|
186 messages has been excluded from this view by a project administrator.
