[Sqlalchemy-commits] [1512] sqlalchemy/trunk/lib/sqlalchemy/orm/unitofwork.py: some TODOs
Brought to you by:
zzzeek
Menu
▾
▴
[Sqlalchemy-commits] [1512] sqlalchemy/trunk/lib/sqlalchemy/orm/unitofwork.py: some TODOs
|
From: <co...@sq...> - 2006-05-25 18:30:46
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><style type="text/css"><!-- #msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; } #msg dt { float: left; width: 6em; font-weight: bold; } #msg dt:after { content:':';} #msg dl, #msg dt, #msg ul, #msg li { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: bold} #msg dl a:link { color:#fc3; } #msg dl a:active { color:#ff0; } #msg dl a:visited { color:#cc6; } h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; } #msg ul, pre { overflow: auto; } #patch { width: 100%; } #patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;} #patch .propset h4, #patch .binary h4 {margin:0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;} #patch .propset .diff, #patch .binary .diff {padding:10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, .info {color:#888;background:#fff;} --></style> <title>[1512] sqlalchemy/trunk/lib/sqlalchemy/orm/unitofwork.py: some TODOs</title> </head> <body> <div id="msg"> <dl> <dt>Revision</dt> <dd>1512</dd> <dt>Author</dt> <dd>zzzeek</dd> <dt>Date</dt> <dd>2006-05-25 13:30:36 -0500 (Thu, 25 May 2006)</dd> </dl> <h3>Log Message</h3> <pre>some TODOs</pre> <h3>Modified Paths</h3> <ul> <li><a href="#sqlalchemytrunklibsqlalchemyormunitofworkpy">sqlalchemy/trunk/lib/sqlalchemy/orm/unitofwork.py</a></li> </ul> </div> <div id="patch"> <h3>Diff</h3> <a id="sqlalchemytrunklibsqlalchemyormunitofworkpy"></a> <div class="modfile"><h4>Modified: sqlalchemy/trunk/lib/sqlalchemy/orm/unitofwork.py (1511 => 1512)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/trunk/lib/sqlalchemy/orm/unitofwork.py 2006-05-25 18:20:39 UTC (rev 1511) +++ sqlalchemy/trunk/lib/sqlalchemy/orm/unitofwork.py 2006-05-25 18:30:36 UTC (rev 1512) </span><span class="lines">@@ -607,10 +607,18 @@ </span><span class="cx"> def execute(self, trans): </span><span class="cx"> """executes this UOWTask. saves objects to be saved, processes all dependencies </span><span class="cx"> that have been registered, and deletes objects to be deleted. """ </span><ins>+ + # a "circular" task is a circularly-sorted collection of UOWTask/UOWTaskElements + # derived from the components of this UOWTask, which accounts for inter-row dependencies. + # if one was created for this UOWTask, it replaces the execution for this UOWTask. </ins><span class="cx"> if self.circular is not None: </span><span class="cx"> self.circular.execute(trans) </span><span class="cx"> return </span><span class="cx"> </span><ins>+ # TODO: apply the same recursive inheritance logic to the cyclical tasks/dependencies + # TODO: add a visitation system to the UOW classes and have this execution called + # from a separate executor object ? (would also handle dumping) + </ins><span class="cx"> self._save_objects(trans) </span><span class="cx"> for dep in self.cyclical_dependencies: </span><span class="cx"> dep.execute(trans, False) </span><span class="lines">@@ -784,7 +792,7 @@ </span><span class="cx"> return buf.getvalue() </span><span class="cx"> </span><span class="cx"> def _dump(self, buf, indent=0, circularparent=None): </span><del>- </del><ins>+ # TODO: the dumper should go into a separate module/class, allow different dumper implementations </ins><span class="cx"> def _indent(): </span><span class="cx"> return " | " * indent </span><span class="cx"> </span></span></pre> </div> </div> </body> </html> |
