[Sqlalchemy-commits] [1332] sqlalchemy/trunk/test: lazyload clause calculation uses anonymous keynam
Brought to you by:
zzzeek
Menu
▾
▴
[Sqlalchemy-commits] [1332] sqlalchemy/trunk/test: lazyload clause calculation uses anonymous keynames for the bind parameters, to avoid compilation name conflicts
|
From: <co...@sq...> - 2006-04-24 19:21:25
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><style type="text/css"><!-- #msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; } #msg dt { float: left; width: 6em; font-weight: bold; } #msg dt:after { content:':';} #msg dl, #msg dt, #msg ul, #msg li { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: bold} #msg dl a:link { color:#fc3; } #msg dl a:active { color:#ff0; } #msg dl a:visited { color:#cc6; } h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; } #msg ul, pre { overflow: auto; } #patch { width: 100%; } #patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;} #patch .propset h4, #patch .binary h4 {margin:0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;} #patch .propset .diff, #patch .binary .diff {padding:10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, .info {color:#888;background:#fff;} --></style> <title>[1332] sqlalchemy/trunk/test: lazyload clause calculation uses anonymous keynames for the bind parameters, to avoid compilation name conflicts</title> </head> <body> <div id="msg"> <dl> <dt>Revision</dt> <dd>1332</dd> <dt>Author</dt> <dd>zzzeek</dd> <dt>Date</dt> <dd>2006-04-24 14:21:12 -0500 (Mon, 24 Apr 2006)</dd> </dl> <h3>Log Message</h3> <pre>lazyload clause calculation uses anonymous keynames for the bind parameters, to avoid compilation name conflicts</pre> <h3>Modified Paths</h3> <ul> <li><a href="#sqlalchemytrunklibsqlalchemymappingpropertiespy">sqlalchemy/trunk/lib/sqlalchemy/mapping/properties.py</a></li> <li><a href="#sqlalchemytrunktestalltestspy">sqlalchemy/trunk/test/alltests.py</a></li> </ul> <h3>Added Paths</h3> <ul> <li><a href="#sqlalchemytrunktestlazytest1py">sqlalchemy/trunk/test/lazytest1.py</a></li> </ul> </div> <div id="patch"> <h3>Diff</h3> <a id="sqlalchemytrunklibsqlalchemymappingpropertiespy"></a> <div class="modfile"><h4>Modified: sqlalchemy/trunk/lib/sqlalchemy/mapping/properties.py (1331 => 1332)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/trunk/lib/sqlalchemy/mapping/properties.py 2006-04-24 01:17:08 UTC (rev 1331) +++ sqlalchemy/trunk/lib/sqlalchemy/mapping/properties.py 2006-04-24 19:21:12 UTC (rev 1332) </span><span class="lines">@@ -18,6 +18,7 @@ </span><span class="cx"> import mapper </span><span class="cx"> import objectstore </span><span class="cx"> from sqlalchemy.exceptions import * </span><ins>+import random </ins><span class="cx"> </span><span class="cx"> class ColumnProperty(MapperProperty): </span><span class="cx"> """describes an object attribute that corresponds to a table column.""" </span><span class="lines">@@ -579,7 +580,7 @@ </span><span class="cx"> </span><span class="cx"> class LazyLoader(PropertyLoader): </span><span class="cx"> def do_init_subclass(self, key, parent): </span><del>- (self.lazywhere, self.lazybinds) = create_lazy_clause(self.parent.noninherited_table, self.primaryjoin, self.secondaryjoin, self.foreignkey) </del><ins>+ (self.lazywhere, self.lazybinds, self.lazyreverse) = create_lazy_clause(self.parent.noninherited_table, self.primaryjoin, self.secondaryjoin, self.foreignkey) </ins><span class="cx"> # determine if our "lazywhere" clause is the same as the mapper's </span><span class="cx"> # get() clause. then we can just use mapper.get() </span><span class="cx"> self.use_get = not self.uselist and self.mapper.query._get_clause.compare(self.lazywhere) </span><span class="lines">@@ -608,7 +609,8 @@ </span><span class="cx"> if self.use_get: </span><span class="cx"> ident = [] </span><span class="cx"> for primary_key in self.mapper.pks_by_table[self.mapper.table]: </span><del>- ident.append(params[primary_key._label]) </del><ins>+ bind = self.lazyreverse[primary_key] + ident.append(params[bind.key]) </ins><span class="cx"> return self.mapper.using(session).get(*ident) </span><span class="cx"> elif self.order_by is not False: </span><span class="cx"> order_by = self.order_by </span><span class="lines">@@ -646,23 +648,33 @@ </span><span class="cx"> </span><span class="cx"> def create_lazy_clause(table, primaryjoin, secondaryjoin, foreignkey): </span><span class="cx"> binds = {} </span><ins>+ reverselookup = {} + + def bind_label(): + return "lazy_" + hex(random.randint(0, 65535))[2:] + </ins><span class="cx"> def visit_binary(binary): </span><span class="cx"> circular = isinstance(binary.left, schema.Column) and isinstance(binary.right, schema.Column) and binary.left.table is binary.right.table </span><span class="cx"> if isinstance(binary.left, schema.Column) and isinstance(binary.right, schema.Column) and ((not circular and binary.left.table is table) or (circular and binary.right is foreignkey)): </span><ins>+ col = binary.left </ins><span class="cx"> binary.left = binds.setdefault(binary.left, </span><del>- sql.BindParamClause(binary.right._label, None, shortname = binary.left.name)) </del><ins>+ sql.BindParamClause(bind_label(), None, shortname = binary.left.name)) + reverselookup[binary.right] = binds[col] </ins><span class="cx"> binary.swap() </span><span class="cx"> </span><span class="cx"> if isinstance(binary.right, schema.Column) and isinstance(binary.left, schema.Column) and ((not circular and binary.right.table is table) or (circular and binary.left is foreignkey)): </span><ins>+ col = binary.right </ins><span class="cx"> binary.right = binds.setdefault(binary.right, </span><del>- sql.BindParamClause(binary.left._label, None, shortname = binary.right.name)) </del><ins>+ sql.BindParamClause(bind_label(), None, shortname = binary.right.name)) + reverselookup[binary.left] = binds[col] </ins><span class="cx"> </span><span class="cx"> lazywhere = primaryjoin.copy_container() </span><span class="cx"> li = BinaryVisitor(visit_binary) </span><span class="cx"> lazywhere.accept_visitor(li) </span><ins>+ #print "PRIMARYJOIN", str(lazywhere), [b.key for b in binds.values()] </ins><span class="cx"> if secondaryjoin is not None: </span><span class="cx"> lazywhere = sql.and_(lazywhere, secondaryjoin) </span><del>- return (lazywhere, binds) </del><ins>+ return (lazywhere, binds, reverselookup) </ins><span class="cx"> </span><span class="cx"> </span><span class="cx"> class EagerLoader(PropertyLoader): </span></span></pre></div> <a id="sqlalchemytrunktestalltestspy"></a> <div class="modfile"><h4>Modified: sqlalchemy/trunk/test/alltests.py (1331 => 1332)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/trunk/test/alltests.py 2006-04-24 01:17:08 UTC (rev 1331) +++ sqlalchemy/trunk/test/alltests.py 2006-04-24 19:21:12 UTC (rev 1332) </span><span class="lines">@@ -34,6 +34,7 @@ </span><span class="cx"> # ORM selecting </span><span class="cx"> 'mapper', </span><span class="cx"> 'selectresults', </span><ins>+ 'lazytest1', </ins><span class="cx"> 'eagertest1', </span><span class="cx"> 'eagertest2', </span><span class="cx"> </span></span></pre></div> <a id="sqlalchemytrunktestlazytest1py"></a> <div class="addfile"><h4>Added: sqlalchemy/trunk/test/lazytest1.py (1331 => 1332)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/trunk/test/lazytest1.py 2006-04-24 01:17:08 UTC (rev 1331) +++ sqlalchemy/trunk/test/lazytest1.py 2006-04-24 19:21:12 UTC (rev 1332) </span><span class="lines">@@ -0,0 +1,92 @@ </span><ins>+from testbase import PersistTest, AssertMixin +import testbase +import unittest, sys, os +from sqlalchemy import * +import datetime + +class LazyTest(AssertMixin): + def setUpAll(self): + global info_table, data_table, rel_table + engine = testbase.db + info_table = Table('infos', engine, + Column('pk', Integer, primary_key=True), + Column('info', String)) + + data_table = Table('data', engine, + Column('data_pk', Integer, primary_key=True), + Column('info_pk', Integer, ForeignKey(info_table.c.pk)), + Column('timeval', Integer), + Column('data_val', String)) + + rel_table = Table('rels', engine, + Column('rel_pk', Integer, primary_key=True), + Column('info_pk', Integer, ForeignKey(info_table.c.pk)), + Column('start', Integer), + Column('finish', Integer)) + + + info_table.create() + rel_table.create() + data_table.create() + info_table.insert().execute( + {'pk':1, 'info':'pk_1_info'}, + {'pk':2, 'info':'pk_2_info'}, + {'pk':3, 'info':'pk_3_info'}, + {'pk':4, 'info':'pk_4_info'}, + {'pk':5, 'info':'pk_5_info'}) + + rel_table.insert().execute( + {'rel_pk':1, 'info_pk':1, 'start':10, 'finish':19}, + {'rel_pk':2, 'info_pk':1, 'start':100, 'finish':199}, + {'rel_pk':3, 'info_pk':2, 'start':20, 'finish':29}, + {'rel_pk':4, 'info_pk':3, 'start':13, 'finish':23}, + {'rel_pk':5, 'info_pk':5, 'start':15, 'finish':25}) + + data_table.insert().execute( + {'data_pk':1, 'info_pk':1, 'timeval':11, 'data_val':'11_data'}, + {'data_pk':2, 'info_pk':1, 'timeval':9, 'data_val':'9_data'}, + {'data_pk':3, 'info_pk':1, 'timeval':13, 'data_val':'13_data'}, + {'data_pk':4, 'info_pk':2, 'timeval':23, 'data_val':'23_data'}, + {'data_pk':5, 'info_pk':2, 'timeval':13, 'data_val':'13_data'}, + {'data_pk':6, 'info_pk':1, 'timeval':15, 'data_val':'15_data'}) + + + def tearDownAll(self): + data_table.drop() + rel_table.drop() + info_table.drop() + + def testone(self): + """tests a lazy load which has multiple join conditions, including two that are against + the same column in the child table""" + class Information(object): + pass + + class Relation(object): + pass + + class Data(object): + pass + + # Create the basic mappers, with no frills or modifications + Information.mapper = mapper(Information, info_table) + Data.mapper = mapper(Data, data_table) + Relation.mapper = mapper(Relation, rel_table) + + Relation.mapper.add_property('datas', relation(Data.mapper, + primaryjoin=and_(Relation.c.info_pk==Data.c.info_pk, + Data.c.timeval >= Relation.c.start, + Data.c.timeval <= Relation.c.finish), + foreignkey=Data.c.info_pk)) + + Information.mapper.add_property('rels', relation(Relation.mapper)) + + info = Information.mapper.get(1) + assert info + assert len(info.rels) == 2 + assert len(info.rels[0].datas) == 3 + +if __name__ == "__main__": + testbase.main() + + </ins></span></pre> </div> </div> </body> </html> |
