[Sqlalchemy-commits] [1210] sqlalchemy/trunk/lib/sqlalchemy/engine.py: except it fails a unit test.

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[1210] sqlalchemy/trunk/lib/sqlalchemy/engine.py: except it fails  a unit test.</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd>1210</dd>
<dt>Author</dt> <dd>zzzeek</dd>
<dt>Date</dt> <dd>2006-03-26 00:29:47 -0600 (Sun, 26 Mar 2006)</dd>
</dl>

<h3>Log Message</h3>
<pre>except it fails  a unit test.  OK, make it ia KeyError</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#sqlalchemytrunklibsqlalchemyenginepy">sqlalchemy/trunk/lib/sqlalchemy/engine.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="sqlalchemytrunklibsqlalchemyenginepy"></a>
<div class="modfile"><h4>Modified: sqlalchemy/trunk/lib/sqlalchemy/engine.py (1209 => 1210)</h4>
<pre class="diff"><span>
<span class="info">--- sqlalchemy/trunk/lib/sqlalchemy/engine.py	2006-03-26 06:26:02 UTC (rev 1209)
+++ sqlalchemy/trunk/lib/sqlalchemy/engine.py	2006-03-26 06:29:47 UTC (rev 1210)
</span><span class="lines">@@ -852,10 +852,10 @@
</span><span class="cx">     def __getitem__(self, key):
</span><span class="cx">         return self.__parent._get_col(self.__row, key)
</span><span class="cx">     def __getattr__(self, name):
</span><del>-        #try:
-        return self.__parent._get_col(self.__row, name)
-        #except:
-        #    raise AttributeError
</del><ins>+        try:
+            return self.__parent._get_col(self.__row, name)
+        except KeyError:
+            raise AttributeError
</ins><span class="cx">     def items(self):
</span><span class="cx">         return [(key, getattr(self, key)) for key in self.keys()]
</span><span class="cx">     def keys(self):
</span></span></pre>
</div>
</div>

</body>
</html>