[Sqlalchemy-commits] [1015] sqlalchemy/trunk/test: more fix to one-to-one: 'unchanged_items' can be
Brought to you by:
zzzeek
From: <co...@sq...> - 2006-02-22 07:46:36
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><style type="text/css"><!-- #msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; } #msg dt { float: left; width: 6em; font-weight: bold; } #msg dt:after { content:':';} #msg dl, #msg dt, #msg ul, #msg li { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: bold} #msg dl a:link { color:#fc3; } #msg dl a:active { color:#ff0; } #msg dl a:visited { color:#cc6; } h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; } #msg ul, pre { overflow: auto; } #patch { width: 100%; } #patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;} #patch .propset h4, #patch .binary h4 {margin:0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;} #patch .propset .diff, #patch .binary .diff {padding:10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, .info {color:#888;background:#fff;} --></style> <title>[1015] sqlalchemy/trunk/test: more fix to one-to-one: 'unchanged_items' can be [None] also with one to one so check for this</title> </head> <body> <div id="msg"> <dl> <dt>Revision</dt> <dd>1015</dd> <dt>Author</dt> <dd>zzzeek</dd> <dt>Date</dt> <dd>2006-02-22 00:29:05 -0600 (Wed, 22 Feb 2006)</dd> </dl> <h3>Log Message</h3> <pre>more fix to one-to-one: 'unchanged_items' can be [None] also with one to one so check for this during delete</pre> <h3>Modified Paths</h3> <ul> <li><a href="#sqlalchemytrunklibsqlalchemymappingpropertiespy">sqlalchemy/trunk/lib/sqlalchemy/mapping/properties.py</a></li> <li><a href="#sqlalchemytrunktestonetoonepy">sqlalchemy/trunk/test/onetoone.py</a></li> </ul> </div> <div id="patch"> <h3>Diff</h3> <a id="sqlalchemytrunklibsqlalchemymappingpropertiespy"></a> <div class="modfile"><h4>Modified: sqlalchemy/trunk/lib/sqlalchemy/mapping/properties.py (1014 => 1015)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/trunk/lib/sqlalchemy/mapping/properties.py 2006-02-22 00:33:38 UTC (rev 1014) +++ sqlalchemy/trunk/lib/sqlalchemy/mapping/properties.py 2006-02-22 06:29:05 UTC (rev 1015) </span><span class="lines">@@ -455,8 +455,9 @@ </span><span class="cx"> for obj in deplist: </span><span class="cx"> childlist = getlist(obj, False) </span><span class="cx"> for child in childlist.deleted_items() + childlist.unchanged_items(): </span><del>- self._synchronize(obj, child, None, True) - uowcommit.register_object(child, postupdate=self.post_update) </del><ins>+ if child is not None: + self._synchronize(obj, child, None, True) + uowcommit.register_object(child, postupdate=self.post_update) </ins><span class="cx"> elif self.association is not None: </span><span class="cx"> # manage association objects. </span><span class="cx"> for obj in deplist: </span></span></pre></div> <a id="sqlalchemytrunktestonetoonepy"></a> <div class="modfile"><h4>Modified: sqlalchemy/trunk/test/onetoone.py (1014 => 1015)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/trunk/test/onetoone.py 2006-02-22 00:33:38 UTC (rev 1014) +++ sqlalchemy/trunk/test/onetoone.py 2006-02-22 06:29:05 UTC (rev 1015) </span><span class="lines">@@ -79,5 +79,8 @@ </span><span class="cx"> self.assert_(p.jack is None) </span><span class="cx"> objectstore.commit() </span><span class="cx"> </span><ins>+ j.delete() + objectstore.commit() + </ins><span class="cx"> if __name__ == "__main__": </span><span class="cx"> testbase.main() </span></span></pre> </div> </div> </body> </html> |