[Sqlalchemy-tickets] Issue #4369: remove depreacted cx_Oracle connect params, let all keywords thro
Brought to you by:
zzzeek
From: Michael B. <iss...@bi...> - 2018-11-15 14:14:49
|
New issue 4369: remove depreacted cx_Oracle connect params, let all keywords through https://bitbucket.org/zzzeek/sqlalchemy/issues/4369/remove-depreacted-cx_oracle-connect-params Michael Bayer: cx_Oracle is moving very fast these days and it now allows a lot of new arguments: https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.Connection we need to at least allow connect_args to travel through generically and we should also string-coerece the ones that are listed in the above document. Additionally, we should not be setting threaded=True. SQLAlchemy connections are not threadsafe in any case. Allow it as an option, make sure we document that this changed. Remove all the unused and warned as deprecated params auto_setinputsizes, allow_twophase, "threaded" as a dialect flag (what's that about anyway?), use_ansi really should not be part of connect_args, it's a dialect flag, as well as auto_convert_lobs. as a bonus, deprecate that these are part of connect_args, but this is not critical. |