[Sqlalchemy-commits] commit/sqlalchemy: zzzeek: Revert cx_Oracle WITH_UNICODE change under > 5.0

[Bitbucket <com...@bi...>]

1 new commit in sqlalchemy:

https://bitbucket.org/zzzeek/sqlalchemy/commits/edeed24d8727/
Changeset:   edeed24d8727
Branch:      rel_1_0
User:        zzzeek
Date:        2017-07-28 21:43:10+00:00
Summary:     Revert cx_Oracle WITH_UNICODE change under > 5.0

Fixed performance regression caused by the fix for :ticket:`3937` where
cx_Oracle as of version 5.3 dropped the ``.UNICODE`` symbol from its
namespace,  which was interpreted as cx_Oracle's "WITH_UNICODE" mode being
turned on unconditionally, which invokes functions on the SQLAlchemy
side which convert all strings to unicode unconditionally and causing
a performance impact.  In fact, per cx_Oracle's author the
"WITH_UNICODE" mode has been removed entirely as of 5.1, so the expensive unicode
conversion functions are no longer necessary and are disabled if
cx_Oracle 5.1 or greater is detected under Python 2.  The warning against
"WITH_UNICODE" mode that was removed under :ticket:`3937` is also restored.

Change-Id: Iddd38d81a5adb27c953a5ee2eae5529a21da16e1
Fixes: #4035
(cherry picked from commit 7997d7fdc3634e7dba9fd0113b8b85ef311bfeaa)

Affected #:  2 files

Repository URL: https://bitbucket.org/zzzeek/sqlalchemy/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.