[Sqlalchemy-commits] commit/sqlalchemy: 2 new changesets
Brought to you by:
zzzeek
From: Bitbucket <com...@bi...> - 2017-03-07 00:13:08
|
2 new commits in sqlalchemy: https://bitbucket.org/zzzeek/sqlalchemy/commits/f4c4f784cde8/ Changeset: f4c4f784cde8 Branch: None User: zzzeek Date: 2017-03-06 22:20:06+00:00 Summary: Don't cache savepoint identifiers Fixed bug in compiler where the string identifier of a savepoint would be cached in the identifier quoting dictionary; as these identifiers are arbitrary, a small memory leak could occur if a single :class:`.Connection` had an unbounded number of savepoints used, as well as if the savepoint clause constructs were used directly with an unbounded umber of savepoint names. The memory leak does **not** impact the vast majority of cases as normally the :class:`.Connection`, which renders savepoint names with a simple counter starting at "1", is used on a per-transaction or per-fixed-number-of-transactions basis before being discarded. The savepoint name in virtually all cases does not require quoting at all, however to support potential third party use cases the "check for quotes needed" logic is retained, at a small performance cost. Uncondtionally quoting the name is another option, but this would turn the name into a case sensitive name which runs the risk of poor interactions with existing deployments that may be looking at these names in other contexts. Change-Id: I6b53c96abf7fdf1840592bbca5da81347911844c Fixes: #3931 Affected #: 3 files https://bitbucket.org/zzzeek/sqlalchemy/commits/b54cefc379dc/ Changeset: b54cefc379dc Branch: master User: zzzeek Date: 2017-03-07 00:12:40+00:00 Summary: Merge "Don't cache savepoint identifiers" Affected #: 3 files Repository URL: https://bitbucket.org/zzzeek/sqlalchemy/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email. |