[Sqlalchemy-commits] commit/sqlalchemy: zzzeek: Move setup functionality into _register_attribute

[Bitbucket <com...@bi...>]

1 new commit in sqlalchemy:

https://bitbucket.org/zzzeek/sqlalchemy/commits/c4a8afa4c6bf/
Changeset:   c4a8afa4c6bf
Branch:      master
User:        zzzeek
Date:        2016-11-06 17:46:28+00:00
Summary:     Move setup functionality into _register_attribute

Options like uselist and backref can be determined from
within _register_attribute based on parent_property
given; move this logic inside so that individual strategies
have less responsibility.  Also don't require that
_register_attribute consider the "strategy" itself
at all; it would be better if we could no longer require
that Joined/Subquery/etc loaders call upon the "lazy" strategy
in order to initialize attribute instrumentation and
this could be done more generically.

Fixes long-standing bug where the "noload" relationship loading
strategy would cause backrefs and/or back_populates options to be
ignored.   There is concern that some application that uses
"noload" might be surprised at a back-populating attribute
appearing suddenly, which may have side effects.  However,
"noload" itself must be extremely seldom used since as a
strategy, it already disables loading, population of attributes
is the only behavior that is even supported, so that this issue has existed
for at least through 0.7 four years ago without ever being
reported indicates extremely low use of this option.

Change-Id: Icffb9c83ac5782b76ce882ed1df4361a1efbfba3
Fixes: #3845

Affected #:  4 files

Repository URL: https://bitbucket.org/zzzeek/sqlalchemy/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.