[Sqlalchemy-tickets] Issue #3435: boolean parsing in engine_from_config wrt engine strategies is in
Brought to you by:
zzzeek
|
From: Mike B. <iss...@bi...> - 2015-05-26 14:40:50
|
New issue 3435: boolean parsing in engine_from_config wrt engine strategies is incorrect https://bitbucket.org/zzzeek/sqlalchemy/issue/3435/boolean-parsing-in-engine_from_config-wrt Mike Bayer: ``` #!diff diff --git a/test/engine/test_parseconnect.py b/test/engine/test_parseconnect.py index fb1f338..dfd39d0 100644 --- a/test/engine/test_parseconnect.py +++ b/test/engine/test_parseconnect.py @@ -138,6 +138,16 @@ class CreateEngineTest(fixtures.TestBase): 'z=somevalue') assert e.echo is True + def test_pool_threadlocal_from_config(self): + dbapi = mock_dbapi + + config = { + 'sqlalchemy.url': 'postgresql://scott:tiger@somehost/test', + 'sqlalchemy.pool_threadlocal': "false"} + + e = engine_from_config(config, module=dbapi, _initialize=False) + eq_(e.pool._use_threadlocal, False) + def test_pool_reset_on_return_from_config(self): dbapi = mock_dbapi ``` fails. We have 'bool' as the handler in default.py and there is no string processing here. |