Re: [Sqlalchemy-tickets] [sqlalchemy] #2932: textasfrom compatibility with columns, query

[sqlalchemy <mi...@zz...>]

#2932: textasfrom compatibility with columns, query
------------------------------+-------------------------------
      Reporter:  zzzeek       |      Owner:  zzzeek
          Type:  defect       |     Status:  reopened
      Priority:  highest      |  Milestone:  0.9.2
     Component:  sql          |   Severity:  major - 1-3 hours
    Resolution:               |   Keywords:
Progress State:  in progress  |
------------------------------+-------------------------------
Changes (by zzzeek):

 * status:  closed => reopened
 * resolution:  fixed =>
 * status_field:  completed/closed => in progress


Comment:

 a few more regressions before we had textasfrom:

 {{{
 #!diff
 diff --git a/test/sql/test_query.py b/test/sql/test_query.py
 index 6e22276..c200878 100644
 --- a/test/sql/test_query.py
 +++ b/test/sql/test_query.py
 @@ -1831,6 +1831,36 @@ class KeyTargetingTest(fixtures.TablesTest):
          assert stmt.c.a in row
          assert stmt.c.b in row

 +    def test_columnclause_schema_column_four(self):
 +        keyed2 = self.tables.keyed2
 +
 +        # this is also addressed by [ticket:2932]
 +
 +        a, b = sql.column('keyed2_a'), sql.column('keyed2_b')
 +        stmt = text("select a AS keyed2_a, b AS keyed2_b from
 keyed2").columns(a, b)
 +        row = testing.db.execute(stmt).first()
 +
 +        assert keyed2.c.a in row
 +        assert keyed2.c.b in row
 +        assert a in row
 +        assert b in row
 +        assert stmt.c.keyed2_a in row
 +        assert stmt.c.keyed2_b in row
 +
 +    def test_columnclause_schema_column_five(self):
 +        keyed2 = self.tables.keyed2
 +
 +        # this is also addressed by [ticket:2932]
 +
 +        stmt = text("select a AS keyed2_a, b AS keyed2_b from
 keyed2").columns(
 +                            keyed2_a=CHAR, keyed2_b=CHAR)
 +        row = testing.db.execute(stmt).first()
 +
 +        assert keyed2.c.a in row
 +        assert keyed2.c.b in row
 +        assert stmt.c.keyed2_a in row
 +        assert stmt.c.keyed2_b in row
 +


  class LimitTest(fixtures.TestBase):
 }}}

 that is, the `ColumnClause` is directly named that of a column._label.

--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2932#comment:2>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python