[Sqlalchemy-tickets] [sqlalchemy] #2873: _parse_rfc1738_args removes '+' symbol from password
Brought to you by:
zzzeek
|
From: sqlalchemy <mi...@zz...> - 2013-11-24 02:29:30
|
#2873: _parse_rfc1738_args removes '+' symbol from password
--------------------+----------------------------------------
Reporter: arun.g | Owner: zzzeek
Type: defect | Status: new
Priority: high | Milestone: 0.9.xx
Component: engine | Severity: trivial - <10 minutes
Keywords: | Progress State: awaiting triage
--------------------+----------------------------------------
AFAIK, '+' symbol only needs to be unquoted to separate form values from
URL. But why function _parse_rfc1738_args in
sqlalchemy/lib/sqlalchemy/engine/url.py uses unquote_plus on password!?
This is wrong, I think.
Following lines of code are replacing '+' symbol in password with space
causing database connection to eventually fail.
if components['password'] is not None:
components['password'] = \
util.unquote_plus(components['password'])
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2873>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|