Re: [Sqlalchemy-tickets] [sqlalchemy] #1631: pg8000 not working with enums.
Brought to you by:
zzzeek
|
From: sqlalchemy <mi...@zz...> - 2013-10-05 19:14:55
|
#1631: pg8000 not working with enums.
-----------------------------------+------------------------------------
Reporter: guest | Owner: zzzeek
Type: defect | Status: closed
Priority: medium | Milestone: 0.6.xx
Component: postgres | Severity: no triage selected yet
Resolution: worksforme | Keywords:
Progress State: completed/closed |
-----------------------------------+------------------------------------
Comment (by tlocke):
This is interesting. Looking at
https://github.com/zzzeek/pg8000/compare/mfenniak:trunk...trunk it seems
that @mfenniak did accept all your changes. I checked, and all your work
is in the HEAD of 'trunk' on the mfenniak repo.
I too have been working on speeding up PG8000, but all of my stuff has
been on the Python 3 version. The two branches were very different when I
started, and now they've diverged even more. It's a shame that the two
versions have divided our efforts. I've not sure what the accepted
strategy is for maintaining Python 2 and 3 libraries, do you have any
views?
Having worked on the speed for py3, I'm now focussing on fixing bugs. With
bugs I've taken the approach of doing the fix to both trunk and py3
branches.
Btw, I had a similar thought to you about simplifying the paramstyles.
I've put my suggestion for DBAPI 3 at:
https://github.com/tlocke/pg8000/tree/three
It removes the 'paramstyle' attribute entirely and just has parameter
labels as :1, :2, :3, ... or the :name style. If it can cast the label to
an int, it assumes the parameters argument is a sequence, otherwise it
assumes it's a mapping. What do you think?
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/1631#comment:9>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|