[Sqlalchemy-tickets] [sqlalchemy] #2825: Index.unique should be only True or False, index=True on C
Brought to you by:
zzzeek
|
From: sqlalchemy <mi...@zz...> - 2013-09-17 03:12:08
|
#2825: Index.unique should be only True or False, index=True on Column breaking
this
--------------------+---------------------------------------
Reporter: zzzeek | Owner: zzzeek
Type: defect | Status: new
Priority: high | Milestone: 0.8.xx
Component: schema | Severity: minor - half an hour
Keywords: | Progress State: needs tests
--------------------+---------------------------------------
{{{
#!python
>>> from sqlalchemy import Table, MetaData, Column, Integer
>>> t1 = Table('t', MetaData(), Column('x', Integer, index=True))
>>> list(t1.indexes)[0].unique
False
}}}
{{{
#!diff
--- a/lib/sqlalchemy/sql/schema.py
+++ b/lib/sqlalchemy/sql/schema.py
@@ -1123,7 +1123,7 @@ class Column(SchemaItem, ColumnClause):
"To create indexes with a specific name, create an "
"explicit Index object external to the Table.")
Index(_truncated_label('ix_%s' % self._label),
- self, unique=self.unique)
+ self, unique=self.unique if
self.unique is not None else False)
elif self.unique:
if isinstance(self.unique, util.string_types):
raise exc.ArgumentError(
}}}
--
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/2825>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python
|