Re: [Sqlalchemy-tickets] [sqlalchemy] #1068: render 'SELECT foo() AS x .. ORDER BY x' by default

[sqlalchemy <mi...@zz...>]

#1068: render 'SELECT foo() AS x .. ORDER BY x' by default
--------------------------------+-------------------------------------------
    Reporter:  jek              |       Owner:  zzzeek                
        Type:  enhancement      |      Status:  reopened              
    Priority:  medium           |   Milestone:  0.5.xx                
   Component:  sql              |    Severity:  no triage selected yet
  Resolution:                   |    Keywords:                        
Status_field:  awaiting triage  |  
--------------------------------+-------------------------------------------
Comment (by zzzeek):

 If you're using the SQL construction lib, you *have* to put `fullname`
 into the ORDER BY.  If you put a `label()` object inside of `ORDER BY`, it
 should render the label unconditionally, why should the compiler try to
 second guess what you did ?   That seems like unnecessary work to be done.

 for the ORM scenario it seems like we'd specifically prevent the ORM from
 putting labels into ORDER_BY.

 If my above points don't fly, then I'm heavily leaning towards rolling
 back the feature and closing the ticket at this point, unless someone else
 wants to take over and can ensure that no function call overhead is added
 to compiler.py.  For the change I made it wasn't a big deal.  But it's now
 inconveniencing me and I really don't need this behavior in the 1st place,
 I don't buy the actual use case as very strong either.

-- 
Ticket URL: <http://www.sqlalchemy.org/trac/ticket/1068#comment:8>
sqlalchemy <http://www.sqlalchemy.org/>
The Database Toolkit for Python