Bug: Total on saved invoice changes when customer tax is edited

[Jonas S. <dr...@jo...>]

Hi Dieter,

I believe the following is a bug in the data storage logic:

1) Create 2 different taxes: "sales tax" and "expense tax" (in Denmark
they are taxed equally but must be tracked and reported separately).

2) Create a new customer (which by default enables both which is wrong,
but leave it as is for now).

3) Create an invoice using the badly configured customer (will be double
taxed) and save it.

4) Edit the customer and correct the error: turn off "expense tax" (which
will never ever be useful here - only for vendors).

5) Find the invoice: the tax calculation has changed!

This is BAD! When I make an invoice I expect that invoice to not change
unless I hit the "update Form" button.

Editing customer/vendor/part/service should apply only to _new_ invoices,
not existing ones.

Currently, published invoices _link_ to entries in the "address book" of
customers/vendors. Correct behavior IMHO would be to _copy_ the info
instead (and possibly re-copy when doing an "Update Form").

I am using SQL-Ledger version 1.8.3.

 - Jonas

-- 
Feel free to quote me wherever. I usually post on d-private because that's
where most developers are. Sadly there's no similar _public_ spot!

Jonas Smedegaard (+45 40843136)          http://dr.jones.dk/~jonas/
Spiff ApS (= IT-guide dr. Jones ApS)     http://dr.jones.dk/
Debian GNU/Linux developer               http://people.debian.org/~js/