Menu
▾
▴
springframework-rcp-dev
|
From: Ryan O. (JIRA) <no...@sp...> - 2010-01-11 16:27:05
|
migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
------------------------------------------------------------------------------------
Key: RCP-624
URL: https://jira.springsource.org/browse/RCP-624
Project: Spring Rich Client Project
Issue Type: Refactoring
Components: Build System
Affects Versions: 1.1.1
Reporter: Ryan Ovrevik
Assignee: Lieven Doclo
Priority: Minor
Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Ryan O. (JIRA) <no...@sp...> - 2010-01-26 19:15:29
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Ovrevik updated RCP-624:
-----------------------------
Attachment: spring-richclient-poms.patch
Added spring enterprise repositories
Updated to utilize spring version 2.5.6.SEC01
Replaced all possible dependencies with corresponding spring-managed dependencies and removed resulting necessary exclusions (verified with dependency:tree)
Added exclusions for remaining spring-binding dependency not available in spring repository.
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Geoffrey De S. (JIRA) <no...@sp...> - 2010-01-27 09:27:05
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50523#action_50523 ]
Geoffrey De Smet commented on RCP-624:
--------------------------------------
-1 on this change
This change says we have to do something like this:
{code}
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
+ <groupId>org.junit</groupId>
+ <artifactId>com.springsource.org.junit</artifactId>
</dependency>
{code}
The advantage is that makes us OSGi ready by using the spring OSGi maven-repistory hack. The disadvantage is that is screws up maven entirely :(
That's because maven doesn't see that junit:junit equals org.junit:com.springsource.org.junit, which gives a total mess with projects depending on us that don't use that spring OSGi maven-repistory hack.
Wait for maven 3 to fix the OSGi story.
Let the the spring OSGi maven-repistory hack become obsolete.
In december 2009 the maven lead said maven 3 would be released this month (january 2010).
Everybody will be happy then :) both OSGi users and non-OSGi users.
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Geoffrey De S. (JIRA) <no...@sp...> - 2010-01-27 09:27:07
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50524#action_50524 ]
Geoffrey De Smet commented on RCP-624:
--------------------------------------
PS: +1 on moving to maven 3 ASAP :)
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Lieven D. (JIRA) <no...@sp...> - 2010-01-27 09:58:04
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50527#action_50527 ]
Lieven Doclo commented on RCP-624:
----------------------------------
+1 voor Maven 3 migration too, although I'd like to wait until it's stabilized (a bugfix release or 2) before we jump on the Maven 3 bandwagon
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Julio A. (J. <no...@sp...> - 2010-01-27 16:15:06
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50538#action_50538 ]
Julio Argüello commented on RCP-624:
------------------------------------
Moving to Spring 3 requires either refactor "Spring Binding" related classes (hard) or keep backwards compatibility mantaining the old fashioned classes ReflectiveVisitorHelper and ResourceMapFactoryBean. Also you will need to modify the BeanWrapper interface adding the #setWrappedInstance(Object) signature.
In my case I did the trick creating an additional maven source folder (src/ext/java) into my project and literally copying the classes above.
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<version>1.3</version>
<executions>
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
<goals>
<goal>add-source</goal>
</goals>
<configuration>
<sources>
<source>src/ext/java</source>
</sources>
</configuration>
</execution>
</executions>
</plugin>
Find attached the related classes
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Julio A. (J. <no...@sp...> - 2010-01-27 16:17:07
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julio Argüello updated RCP-624:
-------------------------------
Attachment: conflictive classes.zip
Left classes when migrating to Spring 3.0
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: conflictive classes.zip, spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Ryan O. (JIRA) <no...@sp...> - 2010-01-29 15:48:20
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50597#action_50597 ]
Ryan Ovrevik commented on RCP-624:
----------------------------------
Geoffrey,
What do you mean by " The disadvantage is that is screws up maven entirely"? Are you referring to the fact that users of the dependencies from the spring repository will have to update their poms to resolves dependencies like commons collections from the spring repo or they run the risk of pulling the dependency (same dependency but... different name)from two places at the same time?
"Let the the spring OSGi maven-repistory hack become obsolete." is this the plan for the spring repo? Was it (the spring repo) intended only to be a short term hack? If that is the case, it does change things. I did not get the impression based on the fact other spring projects use the spring repos internally. Please correct any misunderstandings I have.
For what it is worth... On our projects, we use the spring repositories because they are consistent, cleanly isolated and carefully managed... we don't currently use any of the osgi business. It is great to have a dependency like log4j not not pulling in servlet, mail and jmx because the repo is messed up (just an example).
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: conflictive classes.zip, spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Ryan O. (JIRA) <no...@sp...> - 2010-01-29 15:48:21
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50596#action_50596 ]
Ryan Ovrevik commented on RCP-624:
----------------------------------
Julio,
My intention of this issue was not clearly communicated. This issue was only intended to change the repository and associated dependencies. Unless I am totally off base, I think the points that you are bringing up are related to http://jira.springframework.org/browse/RCP-627.
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: conflictive classes.zip, spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Geoffrey De S. (JIRA) <no...@sp...> - 2010-02-01 09:26:05
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50651#action_50651 ]
Geoffrey De Smet commented on RCP-624:
--------------------------------------
"Are you referring to the fact that users of the dependencies from the spring repository will have to update their poms to resolves dependencies like commons collections from the spring repo or they run the risk of pulling the dependency (same dependency but... different name) from two places at the same time?"
Both, but especially the last :)
The only way to avoid that is to force you to only use artifacts from the spring repo. This means you 'll have ask them and wait to add any additional artifact you need (and totally rewrite the pom while they do that).
The maven central repo is the master repository.
The best person to create a clean, perfect pom is the project owner.
That being said, there's a lot of bugs in the central repo (for example log4j),
but those bugs should be solved in the log4j source repo, where the maven pom.xml resides (or just be added if it's not there yet)
and a new pom should be published. However I can understand that spring can't wait for that to happen and they like direct control.
Spring's repo clones and forks the entire central repo and it's a handy, short-time hack, but I am afraid it will cause fragmentation in the long-run.
Solution to both our problems: Spring can treat spring-richclient as they do hibernate: just clone our pom's and rewrite it to depend on spring's version of dependencies).
PS: log4j is dead for 4 years now, use slf4j with logback (= log4j 2.0, from the same guy who wrote log4J).
See the devoxx presentation on slf4j and logback on parleys.com
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: conflictive classes.zip, spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Lieven D. (JIRA) <no...@sp...> - 2010-02-01 09:43:05
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50652#action_50652 ]
Lieven Doclo commented on RCP-624:
----------------------------------
Geoffrey, while I agree with the fact that moving to Spring's repo would be a bad idea at the moment (I know some people who really wouldn't appreciate the fact that they need to rewrite their POMs just because we're using the Spring OSGi-fied repo), your solution to both problems may (I repeat, may) cause problems. It could be possible that some RCP code is depending on jars that are pulled in transitively. When Spring would just copy our POM's and change the dependencies, it is possible due to their dependency rewiring, some dependencies will be missing. While this is our fault, it is something to take into account.
That said, I am totally in agreement to use logback. Unfortunately, we still don't have a unified logging mechanism when it comes to open source projects. We'd be obliged to include just about every slf4j adapter (java.util Logger, Log4J, commons-logging, ...) to get every working consistently.
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: conflictive classes.zip, spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Lieven D. (JIRA) <no...@sp...> - 2010-02-01 09:43:06
|
[ https://jira.springsource.org/browse/RCP-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50653#action_50653 ]
Lieven Doclo commented on RCP-624:
----------------------------------
*everything
> migrate pom dependencies to come from the SpringSource Enterprise Bundle Repository
> ------------------------------------------------------------------------------------
>
> Key: RCP-624
> URL: https://jira.springsource.org/browse/RCP-624
> Project: Spring Rich Client Project
> Issue Type: Refactoring
> Components: Build System
> Affects Versions: 1.1.1
> Reporter: Ryan Ovrevik
> Assignee: Lieven Doclo
> Priority: Minor
> Attachments: conflictive classes.zip, spring-richclient-poms.patch
>
>
> Update all poms to retrieve dependencies from the SpringSource Enterprise Bundle Repository. This seems like a reasonable precondition for updating the project(s) to utilize spring3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X