springframework-rcp-dev

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-604) Once a MessagableTabbedPane has shown an error icon in its tab because there is an error, the error icon does not dissappear when there are no more errors

[Geoffrey De S. (JIRA) <no...@sp...>]

Once a MessagableTabbedPane has shown an error icon in its tab because there is an error, the error icon does not dissappear when there are no more errors
----------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: RCP-604
                 URL: http://jira.springsource.org/browse/RCP-604
             Project: Spring Rich Client Project
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.1.0
            Reporter: Geoffrey De Smet
            Assignee: Geoffrey De Smet
             Fix For: 1.1.1


bug introduced by jan in revision 2186 and 2187 "Added saving/resetting of old icon/tooltip"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Resolved: (RCP-604) Once a MessagableTabbedPane has shown an error icon in its tab because there is an error, the error icon does not dissappear when there are no more errors

[Geoffrey De S. (JIRA) <no...@sp...>]

     [ http://jira.springsource.org/browse/RCP-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoffrey De Smet resolved RCP-604.
----------------------------------

    Resolution: Fixed

I've fixed it with a boolean oldHasError, following the original default tab icon design.
Nevertheless it feels bad: I don't think it's MessagableTabbedPane's responsibility to remember the default icon of a tab just because the tab has to show an error icon temporary.
Feel free to open an issue to propose a better way of doing this.

Tested if tooltip is still correct after making 2 invalidations and removing the first validation.


> Once a MessagableTabbedPane has shown an error icon in its tab because there is an error, the error icon does not dissappear when there are no more errors
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: RCP-604
>                 URL: http://jira.springsource.org/browse/RCP-604
>             Project: Spring Rich Client Project
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Geoffrey De Smet
>            Assignee: Geoffrey De Smet
>             Fix For: 1.1.1
>
>
> bug introduced by jan in revision 2186 and 2187 "Added saving/resetting of old icon/tooltip"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Reopened: (RCP-604) Once a MessagableTabbedPane has shown an error icon in its tab because there is an error, the error icon does not dissappear when there are no more errors

[Geoffrey De S. (JIRA) <no...@sp...>]

     [ https://jira.springsource.org/browse/RCP-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoffrey De Smet reopened RCP-604:
----------------------------------


This issue still occurs, although only in specific cases.

That class needs to be refactored to readable code first.

> Once a MessagableTabbedPane has shown an error icon in its tab because there is an error, the error icon does not dissappear when there are no more errors
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: RCP-604
>                 URL: https://jira.springsource.org/browse/RCP-604
>             Project: Spring Rich Client Project
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Geoffrey De Smet
>            Assignee: Geoffrey De Smet
>             Fix For: 1.1.1
>
>
> bug introduced by jan in revision 2186 and 2187 "Added saving/resetting of old icon/tooltip"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Resolved: (RCP-604) Once a MessagableTabbedPane has shown an error icon in its tab because there is an error, the error icon does not dissappear when there are no more errors

[Geoffrey De S. (JIRA) <no...@sp...>]

     [ https://jira.springsource.org/browse/RCP-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoffrey De Smet resolved RCP-604.
----------------------------------

    Resolution: Fixed

Fixed, but there is still an improper initialization issue that was already there before & after the regression was introduced
I might look into that improper initialization issue later

> Once a MessagableTabbedPane has shown an error icon in its tab because there is an error, the error icon does not dissappear when there are no more errors
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: RCP-604
>                 URL: https://jira.springsource.org/browse/RCP-604
>             Project: Spring Rich Client Project
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Geoffrey De Smet
>            Assignee: Geoffrey De Smet
>             Fix For: 1.1.1
>
>
> bug introduced by jan in revision 2186 and 2187 "Added saving/resetting of old icon/tooltip"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira