Menu
▾
▴
springframework-rcp-dev
|
From: Arne L. (JIRA) <no...@at...> - 2006-01-21 10:26:20
|
Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer).
------------------------------------------------------------------------------------------------------------------------------------
Key: RCP-267
URL: http://opensource.atlassian.com/projects/spring/browse/RCP-267
Project: Spring Framework Rich Client Project
Type: Improvement
Environment: any
Reporter: Arne Limburg
Assigned to: Oliver Hutchison
Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). I don't consider this as a bug, but this should be done, when a FormBackedWizardPage becomes invisible (due to a click on back or next or via showPage) if it is commitable. At least this should happen on a click on next. I suggest adding the methods isCommittable() and commit() to the FormBackedWizardPage, delegating to the backed Form's FormModel. Then the WizardDialog should call this methods in onNext(), onBack() and showPage() if the current page is an instance of FormBackedWizardPage.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
|
From: Arne L. (JIRA) <no...@at...> - 2006-01-21 10:29:41
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-267?page=comments#action_16128 ] Arne Limburg commented on RCP-267: ---------------------------------- The WizardDialog has to be changed only in showPage(WizardPage), because onNext() and onBack() call this method. > Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). > ------------------------------------------------------------------------------------------------------------------------------------ > > Key: RCP-267 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-267 > Project: Spring Framework Rich Client Project > Type: Improvement > Environment: any > Reporter: Arne Limburg > Assignee: Oliver Hutchison > > Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). I don't consider this as a bug, but this should be done, when a FormBackedWizardPage becomes invisible (due to a click on back or next or via showPage) if it is commitable. At least this should happen on a click on next. I suggest adding the methods isCommittable() and commit() to the FormBackedWizardPage, delegating to the backed Form's FormModel. Then the WizardDialog should call this methods in onNext(), onBack() and showPage() if the current page is an instance of FormBackedWizardPage. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Larry S. (JIRA) <no...@at...> - 2006-05-14 14:26:45
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-267?page=comments#action_17597 ] Larry Streepy commented on RCP-267: ----------------------------------- Automatically committing the underlying form for each wizard page isn't appropriate for all cases. Often, all the pages in the wizard are operating on a single (or hierarchical) form model, so committing as the user moves between pages would be the wrong thing to do. > Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). > ------------------------------------------------------------------------------------------------------------------------------------ > > Key: RCP-267 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-267 > Project: Spring Framework Rich Client Project > Type: Improvement > Environment: any > Reporter: Arne Limburg > Assignee: Oliver Hutchison > > Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). I don't consider this as a bug, but this should be done, when a FormBackedWizardPage becomes invisible (due to a click on back or next or via showPage) if it is commitable. At least this should happen on a click on next. I suggest adding the methods isCommittable() and commit() to the FormBackedWizardPage, delegating to the backed Form's FormModel. Then the WizardDialog should call this methods in onNext(), onBack() and showPage() if the current page is an instance of FormBackedWizardPage. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Arne L. (JIRA) <no...@at...> - 2006-05-15 15:33:47
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-267?page=comments#action_17623 ] Arne Limburg commented on RCP-267: ---------------------------------- OK, you are right. But, is there any opportunity at the current code to realize the behaviour of commiting on next without to much coding? - There is no onNextListener in the WizardContainer - You cannot get the buttons to register a listener - There is no onAboutToHide-Method in the WizardPage interface Am I missing a possibility to do it? My recommendation is to specify onAboutToHide in WizardPage and to implement an attribute commitOnNext in FormBackedWizardPage. For convenience there should be a second addForm-method in AbstractWizard with the signature addForm(Form form, boolean commitOnNext). Other proposals? > Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). > ------------------------------------------------------------------------------------------------------------------------------------ > > Key: RCP-267 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-267 > Project: Spring Framework Rich Client Project > Type: Improvement > Environment: any > Reporter: Arne Limburg > Assignee: Oliver Hutchison > > Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). I don't consider this as a bug, but this should be done, when a FormBackedWizardPage becomes invisible (due to a click on back or next or via showPage) if it is commitable. At least this should happen on a click on next. I suggest adding the methods isCommittable() and commit() to the FormBackedWizardPage, delegating to the backed Form's FormModel. Then the WizardDialog should call this methods in onNext(), onBack() and showPage() if the current page is an instance of FormBackedWizardPage. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Lieven D. (JIRA) <no...@sp...> - 2008-10-09 20:21:19
|
[ http://jira.springframework.org/browse/RCP-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lieven Doclo updated RCP-267:
-----------------------------
Fix Version/s: 1.x
> Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer).
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: RCP-267
> URL: http://jira.springframework.org/browse/RCP-267
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Environment: any
> Reporter: Arne Limburg
> Assignee: Oliver Hutchison
> Fix For: 1.x
>
>
> Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). I don't consider this as a bug, but this should be done, when a FormBackedWizardPage becomes invisible (due to a click on back or next or via showPage) if it is commitable. At least this should happen on a click on next. I suggest adding the methods isCommittable() and commit() to the FormBackedWizardPage, delegating to the backed Form's FormModel. Then the WizardDialog should call this methods in onNext(), onBack() and showPage() if the current page is an instance of FormBackedWizardPage.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
Thanks for helping keep SourceForge clean.
X