Menu
▾
▴
springframework-rcp-dev
|
From: Benoit X. (JIRA) <no...@at...> - 2007-06-03 17:28:29
|
Patch for ShuttleList to improve ergonomics
-------------------------------------------
Key: RCP-475
URL: http://opensource.atlassian.com/projects/spring/browse/RCP-475
Project: Spring Framework Rich Client Project
Issue Type: Improvement
Components: Application Framework
Affects Versions: 0.3.0
Reporter: Benoit Xhenseval
Priority: Trivial
Hi *,
I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
Alternatively, the user can use LEFT or RIGHT appropriately.
The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
Thanks for considering it.
Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Benoit X. (JIRA) <no...@at...> - 2007-06-03 17:30:28
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoit Xhenseval updated RCP-475:
---------------------------------
Attachment: ShuttleList-patch.txt
The patch... trivial and very low risk...
> Patch for ShuttleList to improve ergonomics
> -------------------------------------------
>
> Key: RCP-475
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-475
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Application Framework
> Affects Versions: 0.3.0
> Reporter: Benoit Xhenseval
> Priority: Trivial
> Attachments: ShuttleList-patch.txt
>
>
> Hi *,
> I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
> Alternatively, the user can use LEFT or RIGHT appropriately.
> The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
> Thanks for considering it.
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Geoffrey De S. (JIRA) <no...@at...> - 2007-07-12 11:40:57
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_24772 ]
Geoffrey De Smet commented on RCP-475:
--------------------------------------
LEFT or RIGHT is a really good idea, but the enter key is questionable.
Normally the enter key "sends the form", which doesn't work in textarea's as the enter key types a newline.
However, unlike in textarea's, the enter key doesn't provide functionality that cannot be missed.
Instead of the enter key, I 'd use the space bar, just like in checkboxes.
So I'd like to propose to commit this patch but with the space bar instead of the enter key.
WDYT?
> Patch for ShuttleList to improve ergonomics
> -------------------------------------------
>
> Key: RCP-475
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-475
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Application Framework
> Affects Versions: 0.3.0
> Reporter: Benoit Xhenseval
> Assignee: Geoffrey De Smet
> Priority: Trivial
> Attachments: ShuttleList-patch.txt
>
>
> Hi *,
> I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
> Alternatively, the user can use LEFT or RIGHT appropriately.
> The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
> Thanks for considering it.
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Benoit X. (JIRA) <no...@at...> - 2007-07-12 11:48:00
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_24773 ]
Benoit Xhenseval commented on RCP-475:
--------------------------------------
Hi Geoffrey,
I guess that I could live with that (it is locally modified at the moment...); just diverge from my client's requirements, but I see where you're coming from.
Thanks!
Benoit
> Patch for ShuttleList to improve ergonomics
> -------------------------------------------
>
> Key: RCP-475
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-475
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Application Framework
> Affects Versions: 0.3.0
> Reporter: Benoit Xhenseval
> Assignee: Geoffrey De Smet
> Priority: Trivial
> Attachments: ShuttleList-patch.txt
>
>
> Hi *,
> I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
> Alternatively, the user can use LEFT or RIGHT appropriately.
> The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
> Thanks for considering it.
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Benoit X. (JIRA) <no...@sp...> - 2008-04-07 10:55:03
|
[ http://jira.springframework.org/browse/RCP-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_34428 ]
Benoit Xhenseval commented on RCP-475:
--------------------------------------
Could this patch be committed please?
Geoffrey was in agreement.
Thanks
> Patch for ShuttleList to improve ergonomics
> -------------------------------------------
>
> Key: RCP-475
> URL: http://jira.springframework.org/browse/RCP-475
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Application Framework
> Affects Versions: 1.0.0
> Reporter: Benoit Xhenseval
> Assignee: Geoffrey De Smet
> Priority: Trivial
> Attachments: ShuttleList-patch.txt
>
>
> Hi *,
> I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
> Alternatively, the user can use LEFT or RIGHT appropriately.
> The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
> Thanks for considering it.
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jan H. (JIRA) <no...@sp...> - 2008-04-07 12:18:02
|
[ http://jira.springframework.org/browse/RCP-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_34433 ]
Jan Hoskens commented on RCP-475:
---------------------------------
I assume you're referring to the space instead of enter key? I verified the code and the adjustments that were proposed in the patch are already there.
I'll change the VK_ENTER to VK_SPACE.
> Patch for ShuttleList to improve ergonomics
> -------------------------------------------
>
> Key: RCP-475
> URL: http://jira.springframework.org/browse/RCP-475
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Application Framework
> Affects Versions: 1.0.0
> Reporter: Benoit Xhenseval
> Assignee: Geoffrey De Smet
> Priority: Trivial
> Attachments: ShuttleList-patch.txt
>
>
> Hi *,
> I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
> Alternatively, the user can use LEFT or RIGHT appropriately.
> The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
> Thanks for considering it.
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Benoit X. (JIRA) <no...@sp...> - 2008-04-07 13:27:05
|
[ http://jira.springframework.org/browse/RCP-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_34438 ]
Benoit Xhenseval commented on RCP-475:
--------------------------------------
Hi Jan
Thanks for checking this, I have noticed some differences between my local version and the latest one from SVN.
This may be due to some extra functionality we added. I will review it and if suitable and generic may suggest another patch.
best regards
Benoit
> Patch for ShuttleList to improve ergonomics
> -------------------------------------------
>
> Key: RCP-475
> URL: http://jira.springframework.org/browse/RCP-475
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Application Framework
> Affects Versions: 1.0.0
> Reporter: Benoit Xhenseval
> Assignee: Geoffrey De Smet
> Priority: Trivial
> Attachments: ShuttleList-patch.txt
>
>
> Hi *,
> I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
> Alternatively, the user can use LEFT or RIGHT appropriately.
> The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
> Thanks for considering it.
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Benoit X. (JIRA) <no...@sp...> - 2008-04-07 14:57:12
|
[ http://jira.springframework.org/browse/RCP-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_34446 ]
Benoit Xhenseval commented on RCP-475:
--------------------------------------
Hi Jan,
This JIRA can be closed, the differences were due to some formatting.
Thanks
Benoit
> Patch for ShuttleList to improve ergonomics
> -------------------------------------------
>
> Key: RCP-475
> URL: http://jira.springframework.org/browse/RCP-475
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Application Framework
> Affects Versions: 1.0.0
> Reporter: Benoit Xhenseval
> Assignee: Geoffrey De Smet
> Priority: Trivial
> Attachments: ShuttleList-patch.txt
>
>
> Hi *,
> I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
> Alternatively, the user can use LEFT or RIGHT appropriately.
> The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
> Thanks for considering it.
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jan H. (JIRA) <no...@sp...> - 2008-04-14 17:34:48
|
[ http://jira.springframework.org/browse/RCP-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Hoskens closed RCP-475.
---------------------------
Assignee: Jan Hoskens (was: Geoffrey De Smet)
Resolution: Fixed
Fix Version/s: 1.0.1
As said in comment, it's already fixed.
> Patch for ShuttleList to improve ergonomics
> -------------------------------------------
>
> Key: RCP-475
> URL: http://jira.springframework.org/browse/RCP-475
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Application Framework
> Affects Versions: 1.0.0
> Reporter: Benoit Xhenseval
> Assignee: Jan Hoskens
> Priority: Trivial
> Fix For: 1.0.1
>
> Attachments: ShuttleList-patch.txt
>
>
> Hi *,
> I'd like to propose the attached patch that slightly enhance the ShuttleList. Once one or more items have been selected on the list, pressing ENTER would result in moving those to the next list.
> Alternatively, the user can use LEFT or RIGHT appropriately.
> The Patch will be included, I'd prefer to see that modification on the main trunk than my code...
> Thanks for considering it.
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
Thanks for helping keep SourceForge clean.
X