Menu
▾
▴
springframework-rcp-dev
|
From: Luis S. (JIRA) <no...@at...> - 2007-11-23 16:31:17
|
The label does not get the correct attrbites
--------------------------------------------
Key: RCP-498
URL: http://opensource.atlassian.com/projects/spring/browse/RCP-498
Project: Spring Framework Rich Client Project
Issue Type: Bug
Reporter: Luis Santos
Priority: Critical
when you add a property to a form in the form of
formBuilder.add( propertyName, attributes)
the jLabel is not afected by the attutes defined.
More precisely, if an valign or rowspan attribute is specified it should also be applied to the label.
_Proposal_ of a fix:
replace the method in the class org.springframework.richclient.form.builder.TableFormBuilder
public String getLabelAttributes() {
return labelAttributes;
}
for an alternate implementation
public String getLabelAttributes(String fieldProperties) {
String theLabelAttributes = labelAttributes;
int valignStartIndex = fieldProperties.indexOf(TableLayoutBuilder.VALIGN);
if( valignStartIndex!=-1){
int valignEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
theLabelAttributes += (" "+theLabelAttributes.substring(valignStartIndex, valignEndIndex));
}
int rowStartIndex = fieldProperties.indexOf(TableLayoutBuilder.ROWSPAN);
if( rowStartIndex!=-1){
int rowEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
theLabelAttributes += (" "+theLabelAttributes.substring(rowStartIndex, rowEndIndex));
}
return theLabelAttributes;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Luis S. (JIRA) <no...@at...> - 2007-11-23 17:18:16
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luis Santos updated RCP-498:
----------------------------
Attachment: attributesPatch.txt
A proposed patch to the issue
> The label does not get the correct attrbites
> --------------------------------------------
>
> Key: RCP-498
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-498
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Reporter: Luis Santos
> Priority: Critical
> Attachments: attributesPatch.txt
>
>
> when you add a property to a form in the form of
> formBuilder.add( propertyName, attributes)
> the jLabel is not afected by the attutes defined.
> More precisely, if an valign or rowspan attribute is specified it should also be applied to the label.
> _Proposal_ of a fix:
> replace the method in the class org.springframework.richclient.form.builder.TableFormBuilder
> public String getLabelAttributes() {
> return labelAttributes;
> }
> for an alternate implementation
> public String getLabelAttributes(String fieldProperties) {
> String theLabelAttributes = labelAttributes;
>
> int valignStartIndex = fieldProperties.indexOf(TableLayoutBuilder.VALIGN);
> if( valignStartIndex!=-1){
> int valignEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
> theLabelAttributes += (" "+theLabelAttributes.substring(valignStartIndex, valignEndIndex));
> }
>
> int rowStartIndex = fieldProperties.indexOf(TableLayoutBuilder.ROWSPAN);
> if( rowStartIndex!=-1){
> int rowEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
> theLabelAttributes += (" "+theLabelAttributes.substring(rowStartIndex, rowEndIndex));
> }
>
> return theLabelAttributes;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Peter De B. (JIRA) <no...@at...> - 2007-11-29 07:16:15
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter De Bruycker updated RCP-498:
----------------------------------
Issue Type: New Feature (was: Bug)
changing from bug to new feature
> The label does not get the correct attrbites
> --------------------------------------------
>
> Key: RCP-498
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-498
> Project: Spring Framework Rich Client Project
> Issue Type: New Feature
> Reporter: Luis Santos
> Priority: Critical
> Attachments: attributesPatch.txt
>
>
> when you add a property to a form in the form of
> formBuilder.add( propertyName, attributes)
> the jLabel is not afected by the attutes defined.
> More precisely, if an valign or rowspan attribute is specified it should also be applied to the label.
> _Proposal_ of a fix:
> replace the method in the class org.springframework.richclient.form.builder.TableFormBuilder
> public String getLabelAttributes() {
> return labelAttributes;
> }
> for an alternate implementation
> public String getLabelAttributes(String fieldProperties) {
> String theLabelAttributes = labelAttributes;
>
> int valignStartIndex = fieldProperties.indexOf(TableLayoutBuilder.VALIGN);
> if( valignStartIndex!=-1){
> int valignEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
> theLabelAttributes += (" "+theLabelAttributes.substring(valignStartIndex, valignEndIndex));
> }
>
> int rowStartIndex = fieldProperties.indexOf(TableLayoutBuilder.ROWSPAN);
> if( rowStartIndex!=-1){
> int rowEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
> theLabelAttributes += (" "+theLabelAttributes.substring(rowStartIndex, rowEndIndex));
> }
>
> return theLabelAttributes;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Lieven D. (JIRA) <no...@sp...> - 2008-10-09 19:45:24
|
[ http://jira.springframework.org/browse/RCP-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lieven Doclo updated RCP-498:
-----------------------------
Fix Version/s: 1.x
> The label does not get the correct attrbites
> --------------------------------------------
>
> Key: RCP-498
> URL: http://jira.springframework.org/browse/RCP-498
> Project: Spring Framework Rich Client Project
> Issue Type: New Feature
> Reporter: Luis Santos
> Priority: Critical
> Fix For: 1.x
>
> Attachments: attributesPatch.txt
>
>
> when you add a property to a form in the form of
> formBuilder.add( propertyName, attributes)
> the jLabel is not afected by the attutes defined.
> More precisely, if an valign or rowspan attribute is specified it should also be applied to the label.
> _Proposal_ of a fix:
> replace the method in the class org.springframework.richclient.form.builder.TableFormBuilder
> public String getLabelAttributes() {
> return labelAttributes;
> }
> for an alternate implementation
> public String getLabelAttributes(String fieldProperties) {
> String theLabelAttributes = labelAttributes;
>
> int valignStartIndex = fieldProperties.indexOf(TableLayoutBuilder.VALIGN);
> if( valignStartIndex!=-1){
> int valignEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
> theLabelAttributes += (" "+theLabelAttributes.substring(valignStartIndex, valignEndIndex));
> }
>
> int rowStartIndex = fieldProperties.indexOf(TableLayoutBuilder.ROWSPAN);
> if( rowStartIndex!=-1){
> int rowEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
> theLabelAttributes += (" "+theLabelAttributes.substring(rowStartIndex, rowEndIndex));
> }
>
> return theLabelAttributes;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Lieven D. (JIRA) <no...@sp...> - 2008-11-05 08:36:43
|
[ http://jira.springframework.org/browse/RCP-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lieven Doclo updated RCP-498:
-----------------------------
Component/s: Core
> The label does not get the correct attrbites
> --------------------------------------------
>
> Key: RCP-498
> URL: http://jira.springframework.org/browse/RCP-498
> Project: Spring Rich Client Project
> Issue Type: New Feature
> Components: Core
> Reporter: Luis Santos
> Priority: Critical
> Fix For: 1.x
>
> Attachments: attributesPatch.txt
>
>
> when you add a property to a form in the form of
> formBuilder.add( propertyName, attributes)
> the jLabel is not afected by the attutes defined.
> More precisely, if an valign or rowspan attribute is specified it should also be applied to the label.
> _Proposal_ of a fix:
> replace the method in the class org.springframework.richclient.form.builder.TableFormBuilder
> public String getLabelAttributes() {
> return labelAttributes;
> }
> for an alternate implementation
> public String getLabelAttributes(String fieldProperties) {
> String theLabelAttributes = labelAttributes;
>
> int valignStartIndex = fieldProperties.indexOf(TableLayoutBuilder.VALIGN);
> if( valignStartIndex!=-1){
> int valignEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
> theLabelAttributes += (" "+theLabelAttributes.substring(valignStartIndex, valignEndIndex));
> }
>
> int rowStartIndex = fieldProperties.indexOf(TableLayoutBuilder.ROWSPAN);
> if( rowStartIndex!=-1){
> int rowEndIndex = fieldProperties.indexOf(" ",valignStartIndex);
> theLabelAttributes += (" "+theLabelAttributes.substring(rowStartIndex, rowEndIndex));
> }
>
> return theLabelAttributes;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
Thanks for helping keep SourceForge clean.
X