springframework-rcp-dev

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-500) NullPointerException in AbstractFormBuilder

[Arne L. (JIRA) <no...@at...>]

NullPointerException in AbstractFormBuilder
-------------------------------------------

                 Key: RCP-500
                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-500
             Project: Spring Framework Rich Client Project
          Issue Type: Bug
          Components: Binding System
            Reporter: Arne Limburg


The AbstractFormBuilder throws a NullPointerException when no FormComponentInterceptorFactory is configured, because it calls FormComponentInterceptor.processLabel in createLabel without checking the FormComponentInterceptor to be not null. A simple surrounding with interceptor != null would solve the problem.

Another solution would be to make the FormComponentInterceptorFactories to never return null on getInterceptor.
This should be fixed in the FormComponentInterceptorFactory returned by the formComponentInterceptorFactoryImplBuilder in DefaultApplicationServices. It could just return an anonymous implementation of AbstractFormComponentInterceptor.
The ChainedInterceptorFactory will return null too, if no inner FormComponentInterceptorFactories are configured. It could return an interceptor with an empty list instead.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Resolved: (RCP-500) NullPointerException in AbstractFormBuilder

[Peter De B. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter De Bruycker resolved RCP-500.
-----------------------------------

    Resolution: Fixed

> NullPointerException in AbstractFormBuilder
> -------------------------------------------
>
>                 Key: RCP-500
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-500
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Binding System
>            Reporter: Arne Limburg
>            Assignee: Peter De Bruycker
>
> The AbstractFormBuilder throws a NullPointerException when no FormComponentInterceptorFactory is configured, because it calls FormComponentInterceptor.processLabel in createLabel without checking the FormComponentInterceptor to be not null. A simple surrounding with interceptor != null would solve the problem.
> Another solution would be to make the FormComponentInterceptorFactories to never return null on getInterceptor.
> This should be fixed in the FormComponentInterceptorFactory returned by the formComponentInterceptorFactoryImplBuilder in DefaultApplicationServices. It could just return an anonymous implementation of AbstractFormComponentInterceptor.
> The ChainedInterceptorFactory will return null too, if no inner FormComponentInterceptorFactories are configured. It could return an interceptor with an empty list instead.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-500) NullPointerException in AbstractFormBuilder

[Peter De B. (JIRA) <no...@at...>]

    [ http://opensource.atlassian.com/projects/spring/browse/RCP-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_27955 ] 

Peter De Bruycker commented on RCP-500:
---------------------------------------

fixed by adding a null check in AbstractFormBuilder

> NullPointerException in AbstractFormBuilder
> -------------------------------------------
>
>                 Key: RCP-500
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-500
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Binding System
>            Reporter: Arne Limburg
>            Assignee: Peter De Bruycker
>
> The AbstractFormBuilder throws a NullPointerException when no FormComponentInterceptorFactory is configured, because it calls FormComponentInterceptor.processLabel in createLabel without checking the FormComponentInterceptor to be not null. A simple surrounding with interceptor != null would solve the problem.
> Another solution would be to make the FormComponentInterceptorFactories to never return null on getInterceptor.
> This should be fixed in the FormComponentInterceptorFactory returned by the formComponentInterceptorFactoryImplBuilder in DefaultApplicationServices. It could just return an anonymous implementation of AbstractFormComponentInterceptor.
> The ChainedInterceptorFactory will return null too, if no inner FormComponentInterceptorFactories are configured. It could return an interceptor with an empty list instead.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira