springframework-rcp-dev

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-308) DefaultFormModel should log exception as a warning or error

[Benoit X. (JIRA) <no...@at...>]

DefaultFormModel should log exception as a warning or error
-----------------------------------------------------------

         Key: RCP-308
         URL: http://opensource.atlassian.com/projects/spring/browse/RCP-308
     Project: Spring Framework Rich Client Project
        Type: Bug

  Components: Binding System  
    Versions: 0.2.0    
    Reporter: Benoit Xhenseval


As discussed in http://forum.springframework.org/showthread.php?t=23797

DefaultFormModel catches an exception on line 286 but simply logs it as a debug.
It is probably better to log it as a warning or error.

so I suggest replacing:
...
            }
            catch (Exception e) {
                logger.debug("Exception occurred setting value", e);
                raiseBindingError(this, value, e);
            }

by
...
            }
            catch (Exception e) {
                logger.warn("Exception occurred setting value", e);
                raiseBindingError(this, value, e);
            }

Thank you
Benoit

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-308) DefaultFormModel should log exception as a warning or error

[Jan H. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_32803 ] 

Jan Hoskens commented on RCP-308:
---------------------------------

As I've mentioned on the list (http://thread.gmane.org/gmane.comp.java.springframework.rcp.devel/4997) I still think we should have a Binding exception to filter out the specific exceptions and log these as warnings. Any other exceptions should be thrown up. 

I'll have a look at this.

> DefaultFormModel should log exception as a warning or error
> -----------------------------------------------------------
>
>                 Key: RCP-308
>                 URL: http://jira.springframework.org/browse/RCP-308
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Binding System
>    Affects Versions: 0.2.0
>            Reporter: Benoit Xhenseval
>
> As discussed in http://forum.springframework.org/showthread.php?t=23797
> DefaultFormModel catches an exception on line 286 but simply logs it as a debug.
> It is probably better to log it as a warning or error.
> so I suggest replacing:
> ...
>             }
>             catch (Exception e) {
>                 logger.debug("Exception occurred setting value", e);
>                 raiseBindingError(this, value, e);
>             }
> by
> ...
>             }
>             catch (Exception e) {
>                 logger.warn("Exception occurred setting value", e);
>                 raiseBindingError(this, value, e);
>             }
> Thank you
> Benoit

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Closed: (RCP-308) DefaultFormModel should log exception as a warning or error

[Jan H. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hoskens closed RCP-308.
---------------------------

         Assignee: Jan Hoskens
       Resolution: Fixed
    Fix Version/s: 1.0.0

After examining the defaultFormModel, I noticed that there are two types of exceptions that can originate from the conversion or the beanwrapper that can be seen as binding errors. I've refined the catch level to only catch these two types. Additionally the log level is set to warn to indicate a possible problem.

Fixed in:

http://spring-rich-c.svn.sourceforge.net/viewvc/spring-rich-c?view=rev&revision=1997

> DefaultFormModel should log exception as a warning or error
> -----------------------------------------------------------
>
>                 Key: RCP-308
>                 URL: http://jira.springframework.org/browse/RCP-308
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Binding System
>    Affects Versions: 0.2.0
>            Reporter: Benoit Xhenseval
>            Assignee: Jan Hoskens
>             Fix For: 1.0.0
>
>
> As discussed in http://forum.springframework.org/showthread.php?t=23797
> DefaultFormModel catches an exception on line 286 but simply logs it as a debug.
> It is probably better to log it as a warning or error.
> so I suggest replacing:
> ...
>             }
>             catch (Exception e) {
>                 logger.debug("Exception occurred setting value", e);
>                 raiseBindingError(this, value, e);
>             }
> by
> ...
>             }
>             catch (Exception e) {
>                 logger.warn("Exception occurred setting value", e);
>                 raiseBindingError(this, value, e);
>             }
> Thank you
> Benoit

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira